Pierre Villemot

Results 160 comments of Pierre Villemot

Thanks for the clarification. I thought it was unspecified by the SMT-LIB standard (and it seems it is unclear according to your issue) but I believe that it is better...

This issue should be solved after merging #1281.

Do you want my review? I was reviewing it yesterday.

> Need changes to be able to build, at least [michelmno@f9f949a](https://github.com/michelmno/geneweb/commit/f9f949af7bdbd2c2c972b30d3223a21cc9d3f029) that need review and merge in previous commits. I did not yet tried to test as described above. Thanks...

I fixed several bugs in the search engine in recent commits and rebase the PR too. Some of these issues comes from the implementation of the exponential search I use...

No urge to review this PR, I just rebased on the master.

I report here some issues I found with the gixsql test suite: - The following warning message: ``` Internal warning: unable to join locations via limits in `Cobol_preproc__Src_overlay.join_limits` ``` is...

> But the main problem here is that the orphans rule won't let us implement e.g., DeepModel ... I wish there were an "unsafe" way of disabling orphans check, but...

Sure, your workaround with `#[trusted]` works fine for my crate. Thanks.

The workaround with `#[trusted]` does not work :/ I put this macro on each module declaration in the `lib.rs` file of `hashbrown`, but still I got the error: ``` not...