uncomment install_radis_develop() in setup.py?

[ykawashima]

I just thought it might be good to uncomment install_radis_develop() in setup.py for the time being as the current develop branch keeps installing radis==0.15, causing the issue reported in #458 (radis==0.14 does not cause this error).

But this is just my opinion, and this pull request is just in case you found it useful, too. Please don't hesitate to ignore it otherwise.

[HajimeKawahara]

This is a troubling issue. Currently, several issues ( e.g. radis #636, radis #626, radis #574, radis #571) have been resolved in the develop version of radis, but if we apply the radis master branch (currently radis==0.14) to exojax develop branch, these issues will remain unresolved in the exojax develop branch.

In the short term, since @sh-tada is planning to submit a PR to radis to resolve issue #458, this problem will be resolved temporarily once it gets merged into radis develop branch, but...

What do you think about this issue? @erwanp @minouHub

[HajimeKawahara]

See also #408 radis #597

[minouHub]

Hello all, Just to understand, are you saying you need the develop to be merge in the master?

[HajimeKawahara]

Hello! @minouHub

I think there are two points to consider.

• The first is that the develop branch of exojax installs the develop of radis, but changes in the develop of radis can sometimes cause the develop of exojax to stop working, like #458 . This can be (partially) resolved by implementing unittests in radis for the features required by exojax, as suggested by @erwanp radis #597.
• The second point is that when merging the develop of exojax into the master and releasing a new version, if the develop branch of radis is not also merged into the master, it leads to an odd situation where the release version of exojax installs the develop of radis. For these reasons, I think we should request that the develop version of radis be merged into the master when releasing new version of exojax (this is a bit further down the line).

[minouHub]

I understand that this issue is also discussed in https://github.com/radis/radis/issues/597 and that some tests would help with this issue. However, it would be more convenient that the develop version of any code (including exojax) relies on the master version of radis. For instance, I would not work on a new PR that depends on a temporary version of Numpy, as it is likely to change in the following weeks. In essence, I agree with this PR.

[HajimeKawahara]

Thanks, understood. In that case, I also agree with the direction of this PR. I would like to propose the following, what do you think? @minouHub @ykawashima @erwanp

1. Since the current exojax/develop depends on radis/develop, after the release of radis==0.15, we will change exojax/develop setup.py to install radis==0.15.
2. We will add the unittests being discussed in radis #597 to radis/develop.

By the way, is there a plan to merge radis/develop into radis/master and release radis==0.15 anytime soon?

[ykawashima]

The plan sounds good to me! Thank you.

[minouHub]

@erwanp, we need to talk about merging radis dev into master :)

[HajimeKawahara]

postponed to v1.6

[HajimeKawahara]

I am working on this issue in #500 so I close this PR.