exojax icon indicating copy to clipboard operation
exojax copied to clipboard

Premodit Elower grid error rethinking

Open HajimeKawahara opened this issue 2 years ago • 6 comments

Previously, I estimated a maximum error of delta E_lower. But, it looks too pessimistic. To reduce more memory use, we need to rethink it.

HajimeKawahara avatar Nov 07 '22 04:11 HajimeKawahara

Analytic estimate of the error of line strength using PreMODIT Elower grid: error no dependence on Elower_line

HajimeKawahara avatar Nov 13 '22 07:11 HajimeKawahara

error

HajimeKawahara avatar Nov 13 '22 08:11 HajimeKawahara

I find that I have not checked if a simple T gird instead of Elower in PreMODIT works or not. We'll see.

HajimeKawahara avatar Nov 13 '22 11:11 HajimeKawahara

Errors in LSD as a function of interval_contrast

Tguess = 1000K, comparison with MODIT LSD

T (K) ic=0.1 ic=0.2 ic=0.3
1200K 0.3% 1% 3%
700K 0.5% 2% 5%
T (K) ic=0.1 ic=0.2 ic=0.3
1200K ic0 1_1200K ic0 2_1200K ic0 3_1200K
700K ic0 1_700K ic0 2_700K ic0 3_700K

HajimeKawahara avatar Nov 16 '22 01:11 HajimeKawahara

The above results are completely consistent with the analytic estimate (elower_grid.ipynb)

  • ic=0.2 case

analytic_est

HajimeKawahara avatar Nov 16 '22 01:11 HajimeKawahara

short summary

interval_contrast

  • the errors from the comparison with MODIT (H2O/POKAZATEL) can be reproduced by the analytical model. So, the reason is from the deviation of the (weighted) linear interpolation of two Elower grid points.
  • interval_constant = 0.1 keeps the LSD error within 1% for 250-2000K, assuming Tgue=1000K

analytic_est_ic0 1

elower_grid.ipynb

some indication

We need ~200 grids for Elower in the case of H2O/POKAZATEL, which has large Elower in databases. See the Elower distribution. elower_distribution

freq_elower.ipynb

I feel NE=200 is a bit large. Maybe #317 relaxes the number of grids.. I hope.

HajimeKawahara avatar Nov 16 '22 01:11 HajimeKawahara

I think I did improve the memory use of the E lower grid (Note that we need to multiply 2 to NE to compare the memory use because the derivative of the weight is used)

dE2000 0_700K

dE2000 0_1200K

HajimeKawahara avatar Dec 15 '22 23:12 HajimeKawahara

implemented and PR in #332

HajimeKawahara avatar Feb 13 '23 03:02 HajimeKawahara

Addressed in #332

HajimeKawahara avatar Mar 04 '23 23:03 HajimeKawahara

fig_elower_grid_error

exojax/tests/integration/comparison/premodit/fig_elower_grid_error.py

HajimeKawahara avatar Jun 08 '24 05:06 HajimeKawahara