ngx-avatar icon indicating copy to clipboard operation
ngx-avatar copied to clipboard

Support for Angular 10.x

Open rolfback opened this issue 4 years ago • 15 comments

npm WARN [email protected] requires a peer of @angular/common@^9.0.0 but none is installed.

Works fine with Angular 10.x.

rolfback avatar Oct 30 '20 08:10 rolfback

Related: #108

odahcam avatar Oct 30 '20 14:10 odahcam

Angular 11.....

mhosman avatar Nov 26 '20 16:11 mhosman

PRs still welcome guys. Don't forget there are ready to merge PRs that still didn't got merged because we can't currently deploy a new version.

odahcam avatar Dec 07 '20 13:12 odahcam

I'm waiting for update too. It looks to work with Angular 11.

OldShaterhan avatar Jan 21 '21 14:01 OldShaterhan

@OldShaterhan with the current version?

odahcam avatar Jan 27 '21 21:01 odahcam

@odahcam yup, 11.1.1. Probably only change that should be done is package version compatibility and ES target platform (as far as I remember).

OldShaterhan avatar Jan 28 '21 00:01 OldShaterhan

This issue could be closed, since support has been added with https://github.com/HaithemMosbahi/ngx-avatar/pull/119

Heatmanofurioso avatar Jan 28 '21 10:01 Heatmanofurioso

No, it didn't. The PR was merged but the package was not released, so we still do not have support for Angular 10 unless you build from sources.

odahcam avatar Jan 28 '21 11:01 odahcam

It should be great to give access to any other collaborator to publish new packages

mhosman avatar Jan 28 '21 13:01 mhosman

Yes it should.

odahcam avatar Jan 29 '21 03:01 odahcam

This issue can be closed, as the support has been added

Heatmanofurioso avatar May 03 '21 11:05 Heatmanofurioso

@rolfback Can you close the issue since Haithem doesn't seem to be active in the repo anymore, please?

Heatmanofurioso avatar Nov 03 '21 16:11 Heatmanofurioso

I am at Angular 10 and can't install with following error:

> npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: @angular/[email protected]
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"^10.2.5" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^9.0.0" from [email protected]
npm ERR! node_modules/ngx-avatar
npm ERR!   ngx-avatar@"4.0.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Can't upgrade my Angular to 11 for now, any help is appreciated.

My deps are as follows:

 "dependencies": {
    "@angular/animations": "^10.2.5",
    "@angular/common": "^10.2.5",
    "@angular/compiler": "^10.2.5",
    "@angular/core": "^10.2.5",
    "@angular/forms": "^10.2.5",
    "@angular/platform-browser": "^10.2.5",
    "@angular/platform-browser-dynamic": "^10.2.5",
    "@angular/platform-server": "^10.2.5",
    "@angular/router": "^10.2.5",
    "core-js": "^3.8.3",
    "ngx-avatar": "4.0.0",
    "popper.js": "^1.16.0",
    "rxjs": "^6.6.3",
    "tslib": "^2.0.0",
    "zone.js": "~0.10.2"
  },

iSatishYadav avatar Jul 06 '23 04:07 iSatishYadav

@iSatishYadav, see ngx-avatars on npmjs.

OldShaterhan avatar Jul 06 '23 07:07 OldShaterhan

@iSatishYadav, see ngx-avatars on npmjs.

Apologies. Blunder at my end. Thanks.

iSatishYadav avatar Jul 07 '23 13:07 iSatishYadav