animator icon indicating copy to clipboard operation
animator copied to clipboard

"Show in Finder" for items in Library does not work and does not make sense on non-MacOS systems

Open partytax opened this issue 3 years ago • 2 comments

Clicking the option does nothing.

partytax avatar Sep 29 '21 22:09 partytax

Are you running into this on Linux or macOS/Windows?

There are a couple of places where we change the UI to show "File Explorer" instead of "Finder" for Windows, but this could be made more robust for proper Linux support. See example: https://github.com/HaikuTeam/animator/blob/master/packages/haiku-glass/src/react/Glass.js#L3399

The "Show in Finder" functionality (or Windows Explorer or, say, KDE Dolphin) relies on Electron.Shell.openItem(fullPath: string). Blessedly, openItem just works when passed a directory path on both macOS and Windows, but it may not work out of the box on Linux.

gumptious avatar Sep 30 '21 15:09 gumptious

Running this on Devuan 11 (basically Debian) with Sway window manager. I may need to try this on something like KDE or Gnome to ensure it's not a problem with my system.

partytax avatar Sep 30 '21 15:09 partytax