tmessage icon indicating copy to clipboard operation
tmessage copied to clipboard

Feature-Request: Use paging for showing the recorded conversion rather then files

Open Haider8 opened this issue 6 years ago • 9 comments

Have to be done after #35 is fixed.

Haider8 avatar Oct 07 '19 10:10 Haider8

This issue has to be fixed as #35 is fixed now.

Haider8 avatar Oct 12 '19 12:10 Haider8

Hi,

I would like to attempt this if thats okay?

Grommers00 avatar Oct 13 '19 04:10 Grommers00

Am I thinking incorrectly if that is supposed to say conversation? And you would like it stored in a web version of it?

Grommers00 avatar Oct 14 '19 02:10 Grommers00

Yes I meant to say conversation. No we don't want to store it in a web version. Messages are already stored in a sqlite database and we want paging feature now so that users can see their stored messages from the database.

Haider8 avatar Oct 14 '19 02:10 Haider8

Ah - so just to confirm in the chat they will say something along the lines of "Get chat - %date" and they will get their conversation showing in the CLI?

Grommers00 avatar Oct 14 '19 03:10 Grommers00

For now make it simple, just show the chat which are stored in the database. Order of the messages shown on the cli should be such that recent messages comes first. You can use some library for paging. Please write the code such that it can be utilized in the future in which we have planned to implement personal and group chat feature.

Haider8 avatar Oct 14 '19 14:10 Haider8

Hi Haider, I have submitted a rough draft in the pull request.

It currently grabs the data from the database, and displays it locally. I don't think the timestamp order by needs to be added since if you are not online, it will store it in succession.

There's definitely a lot of potential here, but I think the way messages are stored will need to be saved in conversation form versus the current a message is an entry.

Also one of the tests failed. I am unsure about that one.

Grommers00 avatar Oct 14 '19 22:10 Grommers00

1596277f40b7a231341db0f751e3301a786aee21

Grommers00 avatar Oct 15 '19 12:10 Grommers00

I think I will pass on this one, as I have zero idea of how actual paging works! Sorry!

Grommers00 avatar Oct 15 '19 15:10 Grommers00