PhpStorm 2020.3: Code that doesn't expect named arguments usages

[wbars]

Here are code pieces that we found that may work not correctly with named arguments:

• https://github.com/Haehnchen/idea-php-symfony2-plugin/blob/995fa6e84e1178f671829b34d7a335aa3cc21583/src/main/java/fr/adrienbrault/idea/symfony2plugin/assistant/signature/MethodSignatureTypeProvider.java#L65
• https://github.com/Haehnchen/idea-php-symfony2-plugin/blob/147d6d0951ac64a231e89f7a1e334e2e2d80e2ea/src/main/java/fr/adrienbrault/idea/symfony2plugin/codeInspection/form/FormTypeAsClassConstantInspection.java#L61
• All usages of fr.adrienbrault.idea.symfony2plugin.completion.command.PhpCommandGotoCompletionRegistrar.CommandGotoCompletionProvider#getParameterStringValue
• https://github.com/Haehnchen/idea-php-symfony2-plugin/blob/6826000848b1bc192d5794997933e6c4de9d248a/src/main/java/fr/adrienbrault/idea/symfony2plugin/config/utils/ConfigUtil.java#L130
• https://github.com/Haehnchen/idea-php-symfony2-plugin/blob/133d25ee984ee705d74dc44307e56ecd64e86047/src/main/java/fr/adrienbrault/idea/symfony2plugin/dic/container/util/ServiceContainerUtil.java#L329
• https://github.com/Haehnchen/idea-php-symfony2-plugin/blob/147d6d0951ac64a231e89f7a1e334e2e2d80e2ea/src/main/java/fr/adrienbrault/idea/symfony2plugin/doctrine/querybuilder/QueryBuilderCompletionContributor.java#L400
• https://github.com/Haehnchen/idea-php-symfony2-plugin/blob/d2fc3700a95db389ea8f4c69eddd93bac98a563c/src/main/java/fr/adrienbrault/idea/symfony2plugin/doctrine/querybuilder/QueryBuilderMethodReferenceParser.java#L275
• https://github.com/Haehnchen/idea-php-symfony2-plugin/blob/3ff10237dea144fea8a04d97e14c2a33d2da8178/src/main/java/fr/adrienbrault/idea/symfony2plugin/form/util/FormOptionsUtil.java#L298
• https://github.com/Haehnchen/idea-php-symfony2-plugin/blob/3ff10237dea144fea8a04d97e14c2a33d2da8178/src/main/java/fr/adrienbrault/idea/symfony2plugin/form/util/FormOptionsUtil.java#L317
• https://github.com/Haehnchen/idea-php-symfony2-plugin/blob/793219d39d734b1233d8785c3fe5b629cfdb32a2/src/main/java/fr/adrienbrault/idea/symfony2plugin/templating/util/PhpMethodVariableResolveUtil.java#L312
• https://github.com/Haehnchen/idea-php-symfony2-plugin/blob/4dfa283d2ea6b300609f411c0264f9abbbc1478c/src/main/java/fr/adrienbrault/idea/symfony2plugin/templating/util/TwigExtensionParser.java#L326
• https://github.com/Haehnchen/idea-php-symfony2-plugin/blob/4dfa283d2ea6b300609f411c0264f9abbbc1478c/src/main/java/fr/adrienbrault/idea/symfony2plugin/templating/util/TwigExtensionParser.java#L457
• https://github.com/Haehnchen/idea-php-symfony2-plugin/blob/4dfa283d2ea6b300609f411c0264f9abbbc1478c/src/main/java/fr/adrienbrault/idea/symfony2plugin/templating/util/TwigExtensionParser.java#L559
• https://github.com/Haehnchen/idea-php-symfony2-plugin/blob/76cfaded5a076a50676935cc5332c7b2211cda81/src/main/java/fr/adrienbrault/idea/symfony2plugin/translation/TranslationPlaceholderGotoCompletionRegistrar.java#L124
• https://github.com/Haehnchen/idea-php-symfony2-plugin/blob/d008eea56c3d962d4b460933f075bc529aa2d5be/src/main/java/fr/adrienbrault/idea/symfony2plugin/translation/parser/TranslationPsiParser.java#L97
• https://github.com/Haehnchen/idea-php-symfony2-plugin/blob/995fa6e84e1178f671829b34d7a335aa3cc21583/src/main/java/fr/adrienbrault/idea/symfony2plugin/util/EventDispatcherTypeProvider.java#L54

Generally now it's necessary to take named arguments into account to provide correct behaviour for PHP 8. In 203 build we do have some methods for this to ease the migration. If index is accessible it's recommended to use com.jetbrains.php.PhpWorkaroundUtil#resolveMappedParameterIndex(com.intellij.psi.PsiElement), this method will resolve parameter index taking into account both named argument part and position.

references: https://jetbrains.org/intellij/sdk/docs/products/phpstorm/php_open_api_breaking_changes_203.html