idea-php-symfony2-plugin icon indicating copy to clipboard operation
idea-php-symfony2-plugin copied to clipboard

Fix doctrine repository find() methods not always returning the correct type hints

Open jackbentley opened this issue 4 years ago • 5 comments

I'm not entirely sure how these classes/extension points work and I don't normally code in Java let alone IntelliJ plugins - but this seems to be working for me 🤷‍♂ .

It seems like it wasn't resolving class references correctly. Stripping the class identifiers in the signature solves it so the getSignature() method can find the PHP class and return it as a type hint.

Code review would be appreciated as I don't really know what I'm doing 😂

Potential fix for #1422

jackbentley avatar Feb 27 '20 17:02 jackbentley

After using this build it looks like it doesn't fix the duplicate return type issue as explained in #1422 but it does solve the issue I was referring to in my comment on that issue.

jackbentley avatar Feb 27 '20 17:02 jackbentley

I believe the latest commit now fixes #1422 :)

jackbentley avatar Feb 28 '20 15:02 jackbentley

thanks for this PR, will also comeback here, fixing lost features for API changes ;)

Haehnchen avatar Apr 17 '20 17:04 Haehnchen

Is there any help needed with this PR? Can we do anything to speed up merging and publishing it?

This issue is becoming more and more annoying and fix would be very welcome :)

Also I think it would fix issues reappearing in #1401

Lustmored avatar May 20 '20 13:05 Lustmored

I didn't review, but this really needs attention @Haehnchen ping (please pm me your paypal.me/user/50 if this would help you and to show you my gratitude)

auipga avatar Oct 31 '20 00:10 auipga