idea-php-symfony2-plugin icon indicating copy to clipboard operation
idea-php-symfony2-plugin copied to clipboard

Symfony 4.1 Routing: support double colon changes

Open Haehnchen opened this issue 7 years ago • 6 comments

bundle notation is deprecated. there some condition in routing resolving like services that rely on this :: cleanup this see:

  • https://symfony.com/blog/new-in-symfony-4-1-deprecated-the-bundle-notation
  • https://github.com/symfony/symfony/pull/26085

Haehnchen avatar Mar 17 '18 11:03 Haehnchen

When replacing single colons with double colons in order to fix deprecation notices, I noticed that I can no longer navigate (Ctrl + click) from the routes.yaml to the controller classes.

Perhaps an important detail: we're using service names (controller.login::loginAction) instead of class names (App\LoginController::loginAction).

Any indication when support for the double colons will be added to the plugin? Or can you give me some indications where this is handled, so I can try to send a pull request myself?

nicwortel avatar Sep 17 '18 10:09 nicwortel

Autocompletion for class names in the controller entry in routing is not working. This will be included in this fix?

apfelbox avatar Sep 18 '18 11:09 apfelbox

@apfelbox please open a new issue for this

cedricziel avatar Sep 18 '18 12:09 cedricziel

@cedricziel I have created issue #1231

I created entries for what is and what isn't supported yet and in this ticket this points are of interest:

Cmd+Click works: ✅ 2018-09-20 at 11 43

Missing method is detected: ✅ 2018-09-20 at 11 44

Missing class is not detected: ❌ 2018-09-20 at 11 44

apfelbox avatar Sep 20 '18 09:09 apfelbox

Alright, thank you. I'll have a look at it.

cedricziel avatar Sep 20 '18 09:09 cedricziel

When replacing single colons with double colons in order to fix deprecation notices, I noticed that I can no longer navigate (Ctrl + click) from the routes.yaml to the controller classes.

Perhaps an important detail: we're using service names (controller.login::loginAction) instead of class names (App\LoginController::loginAction).

Any indication when support for the double colons will be added to the plugin? Or can you give me some indications where this is handled, so I can try to send a pull request myself?

Is this something anyone is looking into? It's still doesn't appear to be working (my.controller.service::myAction)

TomHart avatar May 21 '24 15:05 TomHart