crypto-trading-bot icon indicating copy to clipboard operation
crypto-trading-bot copied to clipboard

Confuses 'period' for naming of candles and intervals

Open jorisw opened this issue 3 years ago • 4 comments

Hi,

I admire the cleanliness of most of this project's code. But naming is also very important. And in this project, the word 'period' is used interchangeably to describe candles in some places, vs intervals in other places:

image

Would propose the following naming convention:

  • period: A time period often expressed as a candle. For example: a number of 15m periods are in the lookback and hey a new one just closed. Has open, high, low, close values and those of any indicators.

  • interval: A timeframe interval, sometimes called period length, in which to group trades as candles. For example, 1m, 5m, 15m, 1h, 1d, etc.

jorisw avatar Jan 31 '21 16:01 jorisw

little more i say options.period means what candles would be built and analysed by indicator as well as period() function is how often your strategy is applied with this indicators

litvinenkow avatar Dec 02 '21 19:12 litvinenkow

onPeriod() would then be the correct naming for analysing incoming periods.

jorisw avatar Dec 02 '21 19:12 jorisw

yes, thats it

litvinenkow avatar Dec 03 '21 08:12 litvinenkow

thanks for all, Im new with this bot and now understand my headache. jeje

anakein avatar Apr 14 '22 15:04 anakein