Hadrien G.

`virt::detect()` should return a `Result<Option<Virtualization>>`

5

Not returning a result means that the `Future` returned by this function cannot be made part of a `try_join!`, unlike most other `Future`s in the heim APIs.

[Feature Request] Consider supporting NaiveTime coordinates

1

### What is the feature ? It would be nice if plotters could support time-based coordinates based on chrono's NaiveTime type. I would expect such support to be very similar...

uefi-rs APIs which want a well-aligned buffer but accept &mut [u8] are unsafe

9

If the user-provided slice doesn't actually match the expected alignment, undefined behavior will ensue. FWIW, many of these buffer-wranging APIs actually want to receive an *mut [u8], because they are...

thread_init callback is called multiple times

7

Not sure why...

Is NotificationHandler::shutdown() really safe?

2

If it truly acts like a POSIX signal handler, then it exposes a bewildering range of avenues for undefined behavior and should definitely be an `unsafe fn`.

Dispatch to native vector width

3

This is a continuation of the "dynamic dispatch" discussion of https://github.com/rust-lang/portable-simd/issues/218 , which we all agreed there best belongs here. Basically, I think the current `multiversion` API has two unfortunate...

Advice on toolchain caching

7

So, I have a workflow with a [relatively big build matrix composed of many short jobs](https://github.com/HadrienG2/3photons-rust/runs/431910644). As a result, toolchain downloads are one of the CI perf bottlenecks, which leads...

How would you feel about macrofying more of the implementation?

4

While investigating #105 and #104, I noticed that there is a lot of duplicated patterns in the code, like this sort of function declaration header... ``` #[must_use] #[inline(always)] #[cfg_attr(docs_rs, doc(cfg(target_feature...

Missing 256-bit vpermps ?

2

So, I was looking through the shuffles multiple time, and I did not find an equivalent of the `_mm256_permutevar8x32_ps` Intel intrinsic, which maps into the `vpermps` hardware instruction. According to...

Naming convention cleanup

1

I greatly appreciate the work you did to make naming clearer and more consistent than the Intel intrinsics. That being said, there's still a bit of work to do to...