HEBorn icon indicating copy to clipboard operation
HEBorn copied to clipboard

Swap Component Type with Slot Type for link valitation

Open chrisfls opened this issue 7 years ago • 0 comments

Summary

Components.Type is wrongly used to validate component<->slot matching, but this is wrong, component types should only be used to categorize inventory entries.

No work was done on that before because 99% of the slot types have the same name as the component type, but we'll have to change it in the future.

Proposal

  • Modify: Components.Type => String
    • And localize the name using our future translation mechanism.
  • Add: SlotType, this thing will replace component type for validation.

Reasoning

There are multiple types of HDD slots: sata / nvme, we're not using nvme yet, but we need to prepare for that.

Keep this issue low priority until campaign is almost ready.

chrisfls avatar Dec 16 '17 04:12 chrisfls