react-datepicker icon indicating copy to clipboard operation
react-datepicker copied to clipboard

fix: Inconsistent/broken behavior in `parseDate`

Open laug opened this issue 1 year ago • 4 comments

This is a rebasing of PR #3988 by @maranomynet on top of the current main branch.

Some minor changes relative to the commits in #3988:

  • changed assert to expect in tests
  • file names changed from .js to .ts
  • in index.tsx, removed minDate parameter when calling parseDate

Other than that, same changes and same commit messages with the same 4 commits as PR #3988.

Contribution checklist

  • [X] I have followed the contributing guidelines.
  • [X] I have added sufficient test coverage for my changes.
  • [X] I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

laug avatar Aug 16 '24 16:08 laug

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.93%. Comparing base (ff8b043) to head (88a9dd4). Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5036      +/-   ##
==========================================
+ Coverage   96.87%   96.93%   +0.05%     
==========================================
  Files          30       30              
  Lines        3358     3324      -34     
  Branches     1414     1395      -19     
==========================================
- Hits         3253     3222      -31     
+ Misses        105      102       -3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 28 '24 17:08 codecov[bot]

Can you take a look at the merge conflicts? I think we can release this with a major upgrade soon.

martijnrusschen avatar Aug 28 '24 17:08 martijnrusschen

This should be ready to be merged, but let me know if any further work is required.

laug avatar Sep 01 '24 05:09 laug

Hey all, any thoughts on when this might merge? This is quite valuable for data consistency

jseibert avatar Oct 19 '24 11:10 jseibert

@jseibert I think because this is a breaking change, it requires a major version bump.

@martijnrusschen Is there any timeline for a v8.0 release?

laug avatar Oct 22 '24 15:10 laug

@martijnrusschen Happy New Year! This has been pending for a while now, any chance this could be merged and released as v8?

laug avatar Jan 09 '25 13:01 laug

This one is next on my list. Can you help make sure there are no merge conflicts?

martijnrusschen avatar Jan 21 '25 07:01 martijnrusschen

Merge conflicts have been resolved.

laug avatar Jan 31 '25 08:01 laug