fix DatePikcerProps
Description
Linked issue: closes #4922
Problem See issue
Changes
- Add Partial to
Pick<AdditionalProps, "excludeScrollbar"> - change to optional onSelect and onChangeProps. (Consider defaultProps)
Contribution checklist
- [x] I have followed the contributing guidelines.
- [x] I have added sufficient test coverage for my changes.
- [x] I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.
Codecov Report
Attention: Patch coverage is 71.05263% with 11 lines in your changes missing coverage. Please review.
Project coverage is 96.35%. Comparing base (
f90932c) to head (ee69d7b).
| Files | Patch % | Lines |
|---|---|---|
| src/index.tsx | 71.05% | 11 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #4932 +/- ##
==========================================
- Coverage 96.67% 96.35% -0.32%
==========================================
Files 28 28
Lines 3275 3295 +20
Branches 1357 1392 +35
==========================================
+ Hits 3166 3175 +9
- Misses 109 116 +7
- Partials 0 4 +4
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
it looks like the test coverage took a hit, can you review this?
@martijnrusschen I just formally describe the fallback because defaultProps is not reflected in the type well, and I can't actually get the code to pass here. (I can write this code well if it is a function Component instead of a Class Component.) A similar case occurred during the typescript transition, and we believe that it cannot be helped.
@martijnrusschen Is this PR likely to merge?