[Proposal] yarn to npm
Description: I suggest moving from yarn to npm.
Linked issue: -
Problem
- Some PACKAGES cannot be added or removed because they use yarn v1.
- https://github.com/yarnpkg/yarn/issues/4812
- https://github.com/Hacker0x01/react-datepicker/blob/114f06adfdaee028e3442438cc9bb7c97199be32/docs-site/package.json#L39C6-L39C16
Changes
- Migrated package manager from yarn to npm.
- Fixed Github Actions.
- Removed unnecessary packages that were blocked due to yarn v1.
- Organized the naming of npm scripts since there was no regularity in naming them.
Contribution checklist
- [x] I have followed the contributing guidelines.
- [x] I have added sufficient test coverage for my changes.
- [x] I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.39%. Comparing base (
c550195) to head (84d808f). Report is 417 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #4904 +/- ##
=======================================
Coverage 96.39% 96.39%
=======================================
Files 28 28
Lines 3305 3305
Branches 1387 1400 +13
=======================================
Hits 3186 3186
+ Misses 119 115 -4
- Partials 0 4 +4
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
However, changing from yarn to npm is a fairly significant change to be occurring without previous consensus on doing so.
I agree. I created the PR as a suggestion, hoping that you would be able to judge from the specific changes!
Personally, I don't see the need for it, particularly as there is a workaround that is already being used.
There are some PACKAGES that cannot be deleted due to the use of YARN. https://github.com/Hacker0x01/react-datepicker/pull/4896
I have not had any problems at all with npm.
However this decision is up to the HackerOne team.
I think you are right.
@martijnrusschen What do you think about this change? We are willing to resolve conflicts if the policy seems acceptable.
@martijnrusschen Would it be possible to merge this PR conflict if I fix it?