react-datepicker icon indicating copy to clipboard operation
react-datepicker copied to clipboard
verified publisher icon Hacker0x01

"FindDomNode warning with react strict mode when" using showMonthDropdown and showYearDropdown

Open siddacool opened this issue 2 years ago • 8 comments

I get this error "FindDomNode warning with react strict mode" when using showMonthDropdown and showYearDropdown

To Reproduce:

  1. install version '4.16.0'
  2. set showMonthDropdown option
  3. Open datepicker and click on the month dropdown

Desktop:

  • OS: Windows 10
  • Browser: chrome 116
  • React version: 18.2.0
  • Date picker version: 4.16.0

siddacool avatar Jul 21 '23 07:07 siddacool

Any updates on this?

Seems to be related to onclickoutside component based on this: https://stackoverflow.com/questions/71989683/finddomnode-is-deprecated-in-strictmode-using-react-datepicker-with-react-hook

ovirta avatar Oct 25 '23 09:10 ovirta

Facing same issue

avazhenin avatar Mar 12 '24 08:03 avazhenin

Have you updated to the latest version?

martijnrusschen avatar Mar 12 '24 08:03 martijnrusschen

I tried, but with version 6.3.0 I get error

./node_modules/react-datepicker/node_modules/date-fns/startOfISOWeek.mjs Can't import the named export 'startOfWeek' from non EcmaScript module (only default export is available)

"react": "^17.0.1", "react-scripts: 4.0.0"

so I downgraded react-datepicker to version 4.19.0

avazhenin avatar Mar 13 '24 10:03 avazhenin

Still happening (v6.9.0):

chunk-UJBO7CMO.js?v=d7dedde6:521 Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of YearDropdownOptions2 which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://reactjs.org/link/strict-mode-find-node at div at YearDropdownOptions2 (http://127.0.0.1:3000/zoobenthos/node_modules/.vite/deps/react-datepicker.js?v=d7dedde6:6261:5) at onClickOutside (http://127.0.0.1:3000/zoobenthos/node_modules/.vite/deps/react-datepicker.js?v=d7dedde6:4074:26) at div at YearDropdown2 (http://127.0.0.1:3000/zoobenthos/node_modules/.vite/deps/react-datepicker.js?v=d7dedde6:6360:5) at div at div at div at div at CalendarContainer (http://127.0.0.1:3000/zoobenthos/node_modules/.vite/deps/react-datepicker.js?v=d7dedde6:8245:36) at div at Calendar2 (http://127.0.0.1:3000/zoobenthos/node_modules/.vite/deps/react-datepicker.js?v=d7dedde6:8265:5) at onClickOutside (http://127.0.0.1:3000/zoobenthos/node_modules/.vite/deps/react-datepicker.js?v=d7dedde6:4074:26) at div at div at TabLoop2 (http://127.0.0.1:3000/zoobenthos/node_modules/.vite/deps/react-datepicker.js?v=d7dedde6:9022:5) at PopperComponent2 (http://127.0.0.1:3000/zoobenthos/node_modules/.vite/deps/react-datepicker.js?v=d7dedde6:9095:5) at WithFloating2 (http://127.0.0.1:3000/zoobenthos/node_modules/.vite/deps/react-datepicker.js?v=d7dedde6:9070:30) at DatePicker2 (http://127.0.0.1:3000/zoobenthos/node_modules/.vite/deps/react-datepicker.js?v=d7dedde6:9164:5)

ovirta avatar Jun 11 '24 09:06 ovirta

This is happening because of https://github.com/Pomax/react-onclickoutside/issues/369

martijnrusschen avatar Jun 11 '24 10:06 martijnrusschen

There may be alternative packages that could solve the same use case which may be better maintained. Feel free to open a PR. cc @yuki0410-dev @balajis-qb

martijnrusschen avatar Jun 11 '24 10:06 martijnrusschen

https://github.com/Hacker0x01/react-datepicker/issues/4605

yuki0410-dev avatar Jun 11 '24 12:06 yuki0410-dev