Hacker0x01
added necessary step for getting correct css on calender
When I followed the steps without doing yard css:dev or the equivalent npm command the dropdown calender had no CSS applied, so I added this step to ensure that anyone that runs it locally won't be confused
Hey @luddens heads up I wasn't able to reproduce this. Running yarn build-dev should update the build artifacts - so running it should apply any updates to the SCSS in:
src/stylesheets/datepicker.scss
For CSS assets that will be used (dist/react-datepicker.css). Any direct edits to .css files will be overwritten when you compile SCSS, but running yarn build-dev should eliminate the need to run yard css:dev.
In other words, it really doesn't hurt to have this addition in the Local Development instructions, but it shouldn't be needed.
Any details you can provide about your workflow when you ran into this? It might also be an IDE thing. Which one are you using? There are some tools to just auto-compile SCSS on save (e.g., https://atom.io/packages/sass-autocompile).
@martijnrusschen I think this one can be closed out, unless @luddens I'm missing the mark here.
Okay. I'll upload a video showing me do the npm install, the npm run build-dev and then npm run start to show the css malfunctioning.
Weird that I have to run css:dev too.
On Wed, Sep 14, 2022 at 4:22 PM Dan Mateer @.***> wrote:
@martijnrusschen https://github.com/martijnrusschen I think this one can be closed out, unless @luddens https://github.com/luddens I'm missing the mark here.
— Reply to this email directly, view it on GitHub https://github.com/Hacker0x01/react-datepicker/pull/3755#issuecomment-1247261809, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIP6GX6VCPWNYB5FBADWHDV6IXXFANCNFSM6AAAAAAQJ6OO7U . You are receiving this because you were mentioned.Message ID: @.***>
Okay. I'll upload a video showing me do the npm install, the npm run build-dev and then npm run start to show the css malfunctioning. Weird that I have to run css:dev too.
Ah, possible we're running npm run start here instead of yarn start?
I don't have TEE installed, so that errors out and the CSS never builds properly.
The same thing happens when I run yarn start or npm run start. Hmmm. Interesting. I had to go to court today, spent half the day upstate so I didn't get to make a video of the issue, yet. Basically every time I want to display changes I have to do the css build.
On Wed, Sep 14, 2022 at 4:55 PM Dan Mateer @.***> wrote:
Okay. I'll upload a video showing me do the npm install, the npm run build-dev and then npm run start to show the css malfunctioning. Weird that I have to run css:dev too.
Ah, possible we're running npm run start here instead of yarn start?
— Reply to this email directly, view it on GitHub https://github.com/Hacker0x01/react-datepicker/pull/3755#issuecomment-1247292666, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIP6GR5DNDUFOXY7BYTR5DV6I3UZANCNFSM6AAAAAAQJ6OO7U . You are receiving this because you were mentioned.Message ID: @.***>