react-datepicker
react-datepicker copied to clipboard
Hacker0x01
Add support for seconds to the timepicker
As the title says, this PR is to add support for seconds to the time picker. When using a customTimeInput it will pass HH:mm:ss to the component with this change
Codecov Report
Merging #3214 (3458cef) into master (3d9d0ec) will increase coverage by
0.02%. The diff coverage is90.90%.
:exclamation: Current head 3458cef differs from pull request most recent head 4417161. Consider uploading reports for the commit 4417161 to get more accurate results
@@ Coverage Diff @@
## master #3214 +/- ##
==========================================
+ Coverage 93.32% 93.35% +0.02%
==========================================
Files 20 20
Lines 1349 1369 +20
Branches 375 383 +8
==========================================
+ Hits 1259 1278 +19
Misses 27 27
- Partials 63 64 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/date_utils.js | 99.14% <ø> (ø) |
|
| src/inputTime.jsx | 85.00% <50.00%> (-3.89%) |
:arrow_down: |
| src/calendar.jsx | 92.24% <100.00%> (-0.62%) |
:arrow_down: |
| src/index.jsx | 89.89% <100.00%> (+0.10%) |
:arrow_up: |
| src/time.jsx | 91.66% <100.00%> (+0.14%) |
:arrow_up: |
| src/month.jsx | 95.00% <0.00%> (+1.19%) |
:arrow_up: |
| src/year.jsx | 94.23% <0.00%> (+1.92%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Awesome, can you add some tests to cover the functionality and a docs site example so that others know how to use this too?
Yes I will add some test, docs, and a prop to enable. Thanks Martijn
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
Can you pull in the latest changes from master? It doesn't look like the CI picked up this PR yet.
This PR has a number of commits and merges. I'd like to flatten it into a single commit to clean it up and make it easier to rebase up to master. Have been swamped the past couple weeks at work but hope to get to it soon.
posted a workaround for this issue here: https://github.com/Hacker0x01/react-datepicker/issues/3757
Squashed the multiple commits on this branch into a single commit and force pushed. We now have one commit rebased on top of master. This should make a cleaner PR and easier to move forward.
