react-datepicker icon indicating copy to clipboard operation
react-datepicker copied to clipboard

Date Selected is One Day Off

Open YOO629 opened this issue 7 years ago • 91 comments

Hi, I'm having an interesting issue with my usage of the datepicker component.

My code is pretty basic, it looks like this:

<ReactDatePicker
  onChange={(val) => this.handleChange(val)}
  selected={this.state.currentDate}
/>

and my handler fn

  handleChange(momentDate) {
    console.log(momentDate.toISOString())
    this.setState({currentDate: momentDate});
  }

The issue that I see is that when I select a date from the dropdown, the visual aspects of the component appear to be working fine -- I select 09/10 (sept 10th) and that's what I see in the input field.

However, in my console.log() in my handler function, I see that when I select 09/10, the output is 2017-09-09T21:00:00.000Z. momentDate.toISOString() is ultimately what I'm sending to the DB to be saved, so it's problematic that it's one day off.

I'm not sure what to make of this. I was expecting to see 2017-09-10T21:00:00.000Z. It looks like momentDate is localized, so if I'm in a UTC + 3 timezone and choose 09/10 00:00:00, I'm actually choosing 09/09 21:00:00 (my hypothesis). Even if I set the utcOffset prop to 0 it looks like the localization is still happening.

Am I doing something wrong? Is there a way for me to just kind of...turn off the localization? I'm using the component purely to just pick a day in the calendar. I don't care what timezone they're in, if they pick 09/10, they pick 09/10.

Thanks!

YOO629 avatar Sep 09 '17 08:09 YOO629

Also experiencing this issue.

I open it up, select date its off by 1 day. I then open it up and select any other subsequent day and its correct.

nwkeeley avatar Sep 22 '17 14:09 nwkeeley

I've run into this problem too. This seems to appear in release 0.44.0. From my tests, 0.43.0 behaves correctly and reports the date selected. Release 0.44.0 reports the day prior to the day selected.

From reading through the commits, it's likely that the problem is somewhere in commit a95cd86, but I've not been able to identify the exact cause.

xarxziux avatar Sep 25 '17 10:09 xarxziux

Scrap that last comment. Release 0.43.0 worked fine on a test project, but it's now showing the same error on my main project. The hunt continues...

xarxziux avatar Sep 25 '17 11:09 xarxziux

From further tests, I can actually turn this bug on in a test project using release 0.41.0 just by setting the startDate to null in the constructor function. Setting it to moment() turns the bug off again.

Release 0.40.0 doesn't seem to have this problem.

xarxziux avatar Sep 25 '17 12:09 xarxziux

The same issue for me as well. Do anybody have some workarounds?

romanveryovkin avatar Oct 09 '17 14:10 romanveryovkin

I've just run into a similar sounding issue to this although on closer inspection it seems to be relating to when daylight's savings time ends at the end of October. Selecting a date after this point initially causes the date picker to be one day behind, selecting a date a second time seems to fix this. The 'fix' seems to relate to the moment object having no utc offset the second time - why this is though I'm not sure.

To get around this i'm currently setting the 'utcOffset' prop on the datpicker component to 0 -- this prevents the initial selection from shaowing as the day previous. I'm wondering if this is actually a bug with react-datepicker though or more to do with how dates are handled and manipulated within my app.

RobMaple avatar Oct 17 '17 10:10 RobMaple

@RobMaple Are you able to reproduce it with the examples at https://hacker0x01.github.io/react-datepicker/ ?

DST ends on Nov 5 for me, but selecting days before and after seems to be working. (I tried clearing and not clearing at various points, but it didn't seem to make a difference.)

aij avatar Oct 17 '17 14:10 aij

@aij The example worked fine although when I updated the version of react-datepicker to 0.55 (the same as in my project) the issue returned. Just updated it to 0.56 however and all looks to be working correctly again 😀

RobMaple avatar Oct 17 '17 18:10 RobMaple

This issue is there in v0.58!

aniruddhashevle avatar Nov 01 '17 10:11 aniruddhashevle

We're seeing this issue on 0.61 as well. With some testing, it looks like it only happens in a GMT negative timezone (WEST of GMT). Setting my machine's timezone to a positive value returns a proper date.

Setting the utcOffset prop to 0 doesn't change anything.

mwickett avatar Dec 07 '17 19:12 mwickett

@mwickett @RobMaple Where do you find this utcOffset prob? I can find it on 100 different places

swellmar avatar Dec 14 '17 09:12 swellmar

Using v0.39 it corrects after selecting a second date. For example select 12/20/17 and it will be 12/19/17, then select 12/22/17 and it will be 12/22/17.

Initializing it with a date like @xarxziux mentioned does work.

Edit:

I just undated to v0.64 and it is now working properly even with defaulting to null.

tastypackets avatar Dec 22 '17 20:12 tastypackets

I'm having that exact same bug, and I just understood what's wrong after chasing my own tail for hours. As I'm only interested in dates, in the date selector, the handled value is a Date object with a time set to midnight.

As the selection of the date is in current local time (I'm in CET time), and the storage is in UTC, local time gets shifted by one hour backward when stored. That makes selection of 2018-02-20 with a default to midnight getting stored as 2018-02-19T23:00:00.000Z.

And because in my code I was doing a Q&D conversion from Datetime to string by splitting over T, I was setting the value back to the wrong date.

Solution, in my case? use momentsjs e-ve-ry-whe-re!

guyzmo avatar Feb 14 '18 13:02 guyzmo

I had the same issue,, with the date selected going back a day. I fixed the issue for me by adding

selected={null}

The reason I had it blank was if I had it set as

moment()

it was displaying today rather than my placeholder text

azza85 avatar Mar 12 '18 23:03 azza85

The dates in my app's database were in UTC time with the ISOString format with a "Z" at the end (ie: 2011-10-05T14:48:00.000Z) and I was converting them to Moments as such: Moment("2011-10-05T14:48:00.000Z") but this was using my local UTC offset, causing them to appear one day off.

Creating my dates like this: Moment.utc("2011-10-05T14:48:00.000Z") fixed my issue

ref: https://maggiepint.com/2016/05/14/moment-js-shows-the-wrong-date/

alexjjseppala avatar Apr 06 '18 21:04 alexjjseppala

Still having this issue in 1.4.1, couldn't find a proper solution

omerdn1 avatar May 08 '18 12:05 omerdn1

Having the same problem

jimmytb avatar May 16 '18 11:05 jimmytb

Edit: 17 October - Workaround helps a bit but doesn't solve the issue - see https://github.com/Hacker0x01/react-datepicker/issues/1018#issuecomment-430493313

Workaround

Explicitly add a utcOffset paramater and set it to zero.

It seem the system uses your local utfOffset by default causing a difference in time.

The 'fix' seems to relate to the moment object having no utc offset the second time but using your local system offset the first time.

Example applying the workaround:

<DatePicker
    utcOffset={0}
    dateFormat="DD-MMM HH:mm"
    todayButton="Today in Puerto Rico"
    onChange={this.handleChange}
/>

https://reactdatepicker.com/#example-12

This worked for me. Thanks to @RobMaple

evolve2k avatar Jun 07 '18 06:06 evolve2k

I have the same problem!!

Definence avatar Jul 25 '18 10:07 Definence

The problem still exists in ^1.6.0

olanMbakop avatar Oct 05 '18 10:10 olanMbakop

Updated since I listed my 'Workaround' post on 7 June, seems it's working only when the local time is on the same day as UTC. For me in Australia, this means that half the day it works and the other half of the day it's off-by-one. This is when the user has the datepicker control open and selects a date with the mouse the first time (eg when the date is empty).

Once there is a date present the control works correctly for future selections of dates.

evolve2k avatar Oct 17 '18 05:10 evolve2k

I have the same issue

klijakub avatar Dec 07 '18 15:12 klijakub

Still exists and mine has 7 hours behind. I realize utcOffset props was removed in #1527 #1581 . I tried to set locale using registerLocale, setDefaultLocale and locale props to "id" but nothing happened.

fathurhidayat3 avatar Jan 15 '19 15:01 fathurhidayat3

Still having this issue...

jesseseligman avatar Feb 08 '19 21:02 jesseseligman

Wrapping the string in a moment object and then calling .toDate() seemed to fix this for me. Something like: selected={moment("2019-02-07").toDate()}

jesseseligman avatar Feb 08 '19 22:02 jesseseligman

Still having this issue...

madhukosuri avatar Apr 22 '19 15:04 madhukosuri

I had this issue when I used the dateFormat as "yyyy/MM/dd" When I changed it as below the issue is resolved; showTimeSelect timeFormat="HH:mm" dateFormat="yyyy/MM/dd HH:mm"

cturkdogan avatar Apr 23 '19 05:04 cturkdogan

@cturkdogan thank you, it helps :)

tdubrova avatar Jul 04 '19 10:07 tdubrova

I am still having this problem, yeah it has something to do with the UTC offset

guillecro avatar Jul 08 '19 15:07 guillecro

I had the exact same issue. the first time was one day off the next times it worked correctly. but it wasn't anything wrong with react-datepicker. the problem was in my code when I was trying to get date part this way:

  setSelectedDateInForm = (setFieldValue, name, date) => 
    const onDayOff =date.toISOString().split('T')[0];//wrong
    setFieldValue(name, onDayOff);
  };

setFieldValue is from formik library. don't worry about it. I solved my problem by using the format method from the date-fns library this way:

import {format} from 'date-fns'

  setSelectedDateInForm = (setFieldValue, name, date) => {
    const myDate = format(date,"YYYY-MM-DD").split('T')[0];//right
    setFieldValue(name, myDate);
  };

shahab65 avatar Aug 02 '19 20:08 shahab65