habitica
habitica copied to clipboard
Fixes issue #14175 - Consolidate Challenge category options list to common file
Fixes #14175
Changes
Created common file "categoryOptions.js" to store the category options used in the group sidebar, group form modal, challenge modal, and challenge sidebar on the client. Imported the new file to all four client-side vue files. Replaced the existing statically typed arrays with the new common file. Tested the challenge sidebar and challenge modal successfully. Unable to test the Group sidebar and group form modal due to credit card requirement on local instance.
I'm a first-time contributor so the workflow for tests hasn't run automatically. Please can an admin click the button to start it?
N/A, not a Habitca user.
UUID:
It looks like the reason it failed was:
POST /tasks/unlink-one/:taskId
- [x] ✓ fails if no keep query
- [x] ✓ fails if invalid task id
- [x] ✓ fails on task not found
- [x] ✓ fails on task unlinked to challenge
- [x] ✓ fails on unbroken challenge (43ms)
- [ ] 1) unlinks a task from a challenge and saves it on keep=keep
- [x] ✓ unlinks a task from a challenge and deletes it on keep=remove (76ms)
Is this likely an existing problem? The changes for this PR shouldn't affect unblinking tasks since the only code changed was the array of challenge category options was moved to an external file. I'll keep running tests, but figured I'd ask.
@SabreCat Do you have any input on @Tundrian's question?
Thanks for this, @Tundrian! If you ever do join Habitica proper, let us know and we'll add your contributor credit!