habitica icon indicating copy to clipboard operation
habitica copied to clipboard

Issue with opening and closing the item drawer on smaller screens

Open Tressley opened this issue 2 years ago • 14 comments

On the mobile browser version of Habitica, the item drawer close icon is inaccessible due to tabs overlaying the control.

image

Tressley avatar Mar 30 '22 16:03 Tressley

@Tressley I'd love to take on this one!

vanessasickles avatar Mar 30 '22 17:03 vanessasickles

@vanessasickles -- Thank you!

Tressley avatar Mar 30 '22 17:03 Tressley

Reposting my Blacksmith's Guild message:

My local setup started out pretty smoothly. I followed the documentation here: https://habitica.fandom.com/wiki/Setting_up_Habitica_Locally_on_Windows All went well until the last step of running "npm run client:dev". This is my error:

'vue-cli-service' is not recognized as an internal or external command, operable program or batch file.

I have three integrated terminals (on Windows, so PowerShells) running in Visual Studio Code. First one properly is running the Mongo instance, matching the desired logging output. Second one is properly showing as "connected with mongoose", matching the desired logging output. However, in my third terminal, upon running npm run client:dev, it immediately breaks with the above error.

Any hints or help? Thanks so much in advance!

@Tressley @CuriousMagpie (hope the tag is ok, let me know if not!)

vanessasickles avatar Apr 05 '22 15:04 vanessasickles

Tagging in @SabreCat to see if he can provide any guidance.

Tressley avatar Apr 06 '22 13:04 Tressley

I revisited this and decided to just try continuing to npm install missing packages until it stopped returning them.

Through this chain, I npm installed:

  • vue-cli-service
  • @vue/cli-plugin-babel
  • @vue/cli-plugin-eslint
  • @vue/cli-plugin-unit-mocha
  • vue-cli-plugin-storybook
  • @storybook/core/server

The @storybook/core/server is where I got caught, because npm install @storybook/core/server yields no package.json -- Could not install from "@storybook\core\server" as it does not contain a package.json file.

I'd really like to resolve this issue so I can help contribute! If anyone has any advice, please let me know!

vanessasickles avatar Apr 09 '22 01:04 vanessasickles

@negue -- Are you familiar with this issue? It's related to Storybook.

Tressley avatar Apr 09 '22 12:04 Tressley

@vanessasickles Could it be that you not ran npm install in the website/client folder?

We have the server one in / (root of the repo) and website/client for the client - both need to be installed.

I think after that it should work.

as for the npm install @storybook/core/server npm packages can be only installed with using a name or @org/name sub entries like /server are not packages anymore - just the content of that package

negue avatar Apr 09 '22 13:04 negue

Thank you for the feedback! Deeply sorry that I didn't see this response until now, I'll try this the next time I sit down to work on this! Appreciate it!

vanessasickles avatar Apr 19 '22 17:04 vanessasickles

@vanessasickles Hi there! Were you able to resolve your local installation issues?

CuriousMagpie avatar Jun 03 '22 16:06 CuriousMagpie

@CuriousMagpie Thanks for checking in! I haven't gotten to revisit this yet, but it's back on my radar now. Thanks so much!

vanessasickles avatar Jun 04 '22 03:06 vanessasickles

Hey @vanessasickles! Checking in on this again--are you making any progress?

CuriousMagpie avatar Jul 05 '22 20:07 CuriousMagpie

Hi @CuriousMagpie. Wanted to know if I could try to resolve this issue?

AlexKliger avatar Nov 12 '22 22:11 AlexKliger

Hey @CuriousMagpie,

Just wanted to follow up on this issue and request to work on it again as per the Blacksmith guidelines. I feel that it would be a good first contribution and I believe that I have already found the solution.

AlexKliger avatar Nov 18 '22 15:11 AlexKliger

Hi @AlexKliger, I've gone ahead and reassigned this to you since we haven't heard from @vanessasickles in a while. Thanks!

CuriousMagpie avatar Nov 18 '22 16:11 CuriousMagpie