habitica
habitica copied to clipboard
HabitRPG
Searching challenge participants is inconsistent
@newnonfiction (838936c3-82c4-4998-9580-287f3c9bd4c2): "Hi! I run challenges over at The Wordsmiths and I'm having trouble scrolling through each of the participants to mark progress (the export data feature doesn't gather quite what I need, so I track mostly manually). We usually have about twenty participants each month in our Accountability Club, but only the first ten show up in the "view progress" drop-down. Scrolling doesn't go past the first ten either. If I try to search by name, first letters don't get me anywhere. Sometimes random letters in the middle of someone's name will bring up a participant (my name, for instance, won't come up with "n," but might with "i." I'm on browser when I do this. Thanks!!"
I've confirmed the searching issues myself. For example, in one of my challenges, searching "Q" does not bring up QuartzFox. Searching "fo" does, but searching "fox" does not.
It looks like the search might be case-sensitive, when it needn't be?
EDIT: Oh, wait, that wouldn't replicate the behavior described. Strange... 🤔
Searching "fo" does, but searching "fox" does not.
Does someone know how to replicate this? When I try to do this it doesn't bring up QuartzFox because the search is case-sensitive. But even when I type "Fo" or "Fox", the latter always works better for me, narrowing down the list of participants.
my name, for instance, won't come up with "n," but might with "i."
I can understand how the above may occur because of the 10 users limit and the inability to scroll down (for example the user we search for might be an 11th user to display when we type "n" and 5th when we type "i" - too many users with "n" in their usernames). From my perspective the issue here is the inability to scroll.
This challenge is currently displaying this problem: https://habitica.com/challenges/71e7e92f-131d-459f-95cb-9286fc1fc795
If I search "Quartz", I see QuartzFox.
If I type "fo", I see these users and not QuartzFox.
At the moment, the pattern I can see is that it's due to capitalisation: if I type "Fox", QF does show up, and if I type "quartz", she doesn't.
I can't reproduce the issue I had before.
(Sorry, QF! Don't mean to take your name in vain, just knew you were a member of the challenge!)
@bigsee this should be up for grab now but I've noticed you've already quite a few issues in progress, do you want to wait until those are fixed?
hey @paglias
Yeah, I speculatively commented on a few to see if at least one was free. Ended up with three. I guess it's like waiting for buses... :)
Just made a PR for the highest priority and moving onto the second one (medium). Happy to look at this one too if it's OK with you?
@bigsee I think that there are a couple of related issues here if you want to give a look at them while working on this:
- https://github.com/HabitRPG/habitica/issues/10242
- https://github.com/HabitRPG/habitica/issues/9755
@paglias sure thing! happy to take a look at these together and come back if the solutions are beyond my current skill level...
Quick update: just got back from holidays. I'm on this. Will likely be spending some more time this weekend.
Since I didn't get a reply and I can't spot any activity, I'm putting this back as help wanted again, but if you'd like to pick it up again, just let us know, @bigsee!
I think, that only the user names are being searched (taking capitalisation into account) but not the display names, so people with non-matching user and display names are hard to find. But when searching for the username one can pick any part of the name, so that you find "QuartzFox" when searching "Fox" or even "art" but with "fox" you only find people who have "fox" in their username.
If so, the following issue might be related, where only the display names are searched instead of the usernames: #12729 (might also explain why I got the impression that it was possible to search by both, user and display name, in the past).
Aside from that there appears to be a processing speed/sync issue...? E.g. I tried searching for newnonfiction in the challenge mentioned above by typing a few different bits of the username and had absolutely no issues finding them until I tried "ew". Those two letters are right next to each other on my keyboard and if I type them really fast right after one another, I can't find newnonfiction, however if I wait for the website to load/sync after each letter, there's no issue with finding them with "ew". I had no problem finding them with just the letter "n" (but there were indeed quite a few people in the list)
@paglias Would adding a search by both username and display name fix this issue? I'm not sure exactly what state this is in.
@jbusa22 I think this is ready to be tackled if you want to give it a try! Given the issue description I'm not sure it's just a matter of adding an username search
@paglias Is there an updated test case that can replicate this? I've tested it a bit on the live open server challenges and can't find anything. I think users might just be confused thinking the search is by display name.
@jbusa22 not that i'm aware, if it's not possible to replicate it using the steps outlined at https://github.com/HabitRPG/habitica/issues/11304#issuecomment-666418396 it might have been resolved