habitica icon indicating copy to clipboard operation
habitica copied to clipboard

Update achievements to work with notification object

Open phillipthelen opened this issue 5 years ago • 6 comments

The way achievements are displayed on web is often done by comparing the fields directly. Instead the server should update the notifictations property on the user to add information about the gained notification. Same way it is already done for the Ultimate Gear achievements or Back to basics. This is essential for the achievements to work properly across the mobile apps and the website.

List of achievements that need to be updated:

I marked this as Help Wanted in case a contributor wants to work on one or multiple of these before I have time.

phillipthelen avatar Jul 08 '19 14:07 phillipthelen

Hello @phillipthelen! Is it still Help wanted issue? As I can see we already have PR for that

Xaz16 avatar Sep 14 '19 08:09 Xaz16

@Xaz16 I'll remove the label as this is being handled by @phillipthelen

paglias avatar Sep 14 '19 08:09 paglias

@paglias thank you :)

Xaz16 avatar Sep 14 '19 08:09 Xaz16

@SabreCat Should this one get a Help Wanted tag again?

beffymaroo avatar Oct 05 '21 20:10 beffymaroo

oh gosh, absolutely. Not touched since 2019!

SabreCat avatar Oct 14 '21 20:10 SabreCat

I'll take this one, too, since I'm also handling #11541 and they're related.

CuriousMagpie avatar Nov 16 '21 19:11 CuriousMagpie