habitica
habitica copied to clipboard
HabitRPG
Creating a Guild Challenge doesn't mention Gem bank
Description
As reported by cTheDragons in the Report a Bug Guild:
When creating a challenge it no longer states where the gems are coming from When creating a challenge it not clear when creating the challenge if the gems are coming from the guild or yourself. Can be a little confusing to new players.
as an initial step can I please know how can I get started...I am newbie to open source :)
@arunikayadav42 I'm sorry about the delay! The Guidance for Blacksmiths wiki page is a good place to start learning about Habitica's code and how to contribute. It links to a couple of other important pages about setting up a local install and then using the install for creating new code and pull requests. If you have any generic questions, the Aspiring Blacksmith's guild is a good place to ask (there's a link to it in that page too). Questions about this specific issue can be posted here!
@Alys Oh, I pointed them there already over on https://github.com/HabitRPG/habitica/issues/10448! (Though I suppose I jumped straight to local install, whoops)
Ah! Yes, I remember that now. Sorry, Sabe! The local install page has links back to Guidance for Blacksmiths so it's a good starting point too. :)
@arunikayadav42 Are you still interested in working on this issue? Please update us when you have a moment. Thank you!
@arunikayadav42 Since we haven't heard from you, I'm putting this issue back in "Help Wanted." You're welcome to ask for it again if it's not claimed by the time you see this message.
Do we have copy for this and do we already have tooltips used in forms somewhere?
I can knock this one out, but I believe we would need additional translations...
@BlkStormy do you mean non-english translations? no worries about them , they'll get added later
I can try my hand at this if no one has picked it up!
Is the desired functionality that the language around the Prize box should be more verbose? Does the prize from a challenge always come from the guild bank? I was thinking maybe we could do something like in the picture below. I tried adding the gem SVG within the input box but was getting the following error: 'input is a self closing element: but contains nested content.'. I'm new to vue and, granted I didn't try for too long, but I'm not sure yet how to get that functionality out of it.
If the person creating a challenge is NOT the guild leader, then the Gems always come from their own balance.
If the person creating a challenge IS the group's leader AND there are any Gems in the group's Bank, then the Gems will be taken from the Bank. If the challenge's prize is more than the number of Gems in the Bank, all the Gems in the Bank will be used and the remaining Gems will come from the challenge creator's own balance.
I'm not sure how complex we want this fix to be. The simplest approach would be to include a static message explaining all that, but that would be very verbose. A more complex approach would be:
- When the challenge creation form appears, when it fetches a list of groups that the user is a member of, it also fetches the leaders and bank balances.
- When the user chooses a group, the form's code checks to see if the user is the leader. If not, there's no special handling needed.
- If the user is the leader, the form's code checks the group's balance and the gem prize and displays an appropriate message to indicate the location(s) that the gems will come from.
- Parties shouldn't have special handling in this code. Currently Parties can't have Gems in their Bank but that might change in future, so this code should be written with that in mind (which should just mean you don't need to do anything special for Parties versus Guilds at all). Currently all Parties will have 0 Gems in their Bank so the code described above should correctly indicate that the challenge Gems will come from the user's balance.
@CBillings92 You might want to wait to see if any staff comment here about how they see this working.
@CBillings92 If you're still thinking of working on this, I approve @Alys's suggestions above!
