habitica-ios icon indicating copy to clipboard operation
habitica-ios copied to clipboard

experience bar breaks in party member list

Open rilygreat opened this issue 2 years ago • 2 comments

A party members exp bar is longer than the bar. This probably should not happen anyway, but the view should handle this with a max length anyway. image0

rilygreat avatar Apr 24 '22 16:04 rilygreat

this happens when someone in the party finishes a quest and gets more than their max xp before leveling (which is a longstanding issue). the exp bar should have a max set so even when the number goes beyond the max, the bar doesn't keep growing

saraolson avatar Apr 25 '22 12:04 saraolson

Hi @saraolson,

I would like to work on this issue.

Thanks! Dan

dan-e-miller avatar Sep 24 '22 00:09 dan-e-miller

I just went ahead and posted a PR for this issue.

@saraolson, I'm running into issues with the Continuous Integration tests. The change I posted fixes the issue and is very simple, using syntax and formatting already used in multiple other places in the app. Any chance there could be issues with the tests themselves or the CI environment? Otherwise I'm happy to make any updates that are needed for the tests to pass.

dan-e-miller avatar Sep 25 '22 14:09 dan-e-miller

I am also experiencing issues with the tests. Not in particular with this issue, but with others I worked on. They have never worked for me 🙈

EricMiddelhove avatar Sep 25 '22 15:09 EricMiddelhove

I am also experiencing issues with the tests. Not in particular with this issue, but with others I worked on. They have never worked for me 🙈

Thanks @EricMiddelhove - reassuring that it's not just me 🙂

dan-e-miller avatar Sep 25 '22 15:09 dan-e-miller