habitica-chat-extension icon indicating copy to clipboard operation
habitica-chat-extension copied to clipboard

Published 20 hours ago • verified publisher icon HabitRPG

Remove activeTab permission request

Open SabreCat opened this issue 2 years ago • 2 comments

We received this notice from the Chrome Web Store:

image

On a search, the critique looks accurate--while we use storage in various places, the only place activeTab appears is in the manifest.json. This PR removes the permission request from the manifest.

SabreCat avatar Jul 01 '22 21:07 SabreCat

From my testing on Firefox 105.0.1 (64-bit) appears to be have been working. The only issue is the version is not updated in the extensions or Readme file. (Had to do a lot of double checking to make sure we have the right one)

Tested:

  • Auto connect via the option at the top
  • Retrieving messages from a guild/tavern
  • Updated while chat is open
  • add a message in a guild
  • liking a message
  • removing a like
  • reporting a message
  • checking info of a player
  • Quick reply on name and avatar
  • Keyboard shortcut of ctrl-Enter works

All tested on default options but did open up on large text no avatar to confirm these options work too.

cTheDragons avatar Oct 03 '22 10:10 cTheDragons

From my testing on 105.0.5151.0 (Developer Build) (64-bit) appears to be have been working. Four Bugs:

  • Error reported by the plugin Manifest version 2 is deprecated, and support will be removed in 2023. See https://developer.chrome.com/blog/mv2-transition/ for more details.
  • Issue is the version is not updated in the extensions or Readme file. (Had to do a lot of double checking to make sure we have the right one)
  • The Snowman transformation does not show correctly however I believe this is an existing bug.
  • The Spooky transformation is not align correctly. However I believe this an existing bug.

Tested:

  • Auto connect via the option at the top
  • Retrieving messages from a guild/tavern
  • Updated while chat is open
  • add a message in a guild
  • liking a message
  • removing a like
  • reporting a message
  • checking info of a player
  • Quick reply on name and avatar
  • Keyboard shortcut of ctrl-Enter works
  • Images displayed in chat
  • Transformations show in the chat for flower, star, spooky. As noted above Snowman does not show. Spooky is also shown off centre.

All tested on default options but did open up on large text no avatar to confirm these options work too.

cTheDragons avatar Oct 04 '22 21:10 cTheDragons