habitica-android icon indicating copy to clipboard operation
habitica-android copied to clipboard

Feature request: Fingerprint lock.

Open DanielKaparunakis opened this issue 7 years ago • 4 comments

Currently, there doesn't seem to be an option for the user to lock access to the app other than maybe logging off once the he/she is done with the session. Having to log in and out is not the best idea, especially since my best guess is that user sessions in Habitica are many but very short, therefore, I propose adding a setting to enable a fingerprint lock.

DanielKaparunakis avatar Sep 30 '16 05:09 DanielKaparunakis

There seems to be no easy way to do this without writing a bunch of custom UI. I was hoping to find a library that would do the heavy lifting there, but this way we don't really have the time to implement this right now.

phillipthelen avatar Mar 18 '20 14:03 phillipthelen

Picked up.

AKalinins avatar Jul 05 '22 10:07 AKalinins

@phillipthelen @saraolson I prepared the changes. Where do I point my pull request? Branch 3.6 can't be compiled since in the manifest there is a reference to the recourse string that doesn't exist, so I can't test my changes there. 3.5.3 works fine, should I use this branch instead? Thanks

AKalinins avatar Jul 06 '22 15:07 AKalinins

@AKalinins due to the age of this issue and the fact it's a new feature, our team will be reviewing if this is something we want to release and support when reviewing the implementation in the PR.

phillip is our sole mobile developer on staff and is currently busy with upcoming updates and features we've been planning for awhile now, so it may be some time before we get around to reviewing this PR. i've notified him of your issue with 3.6.

thanks for your patience and interest in helping Habitica!

saraolson avatar Jul 08 '22 16:07 saraolson