habitica-android icon indicating copy to clipboard operation
habitica-android copied to clipboard

Rewards aren't properly in line with each other

Open shanaqui opened this issue 3 years ago • 5 comments

User-created rewards and system rewards aren't quite in line:

image

Device: OnePlus OnePlus 6 Android Version: 29 AppVersion: Version 3.1 (2651) BETA User ID: 874e648a-2df7-4312-a9e6-7217be462204 Level: 70 Class: warrior Is in Inn: false Uses Costume: true Custom Day Start: 0 Timezone Offset: 0

I can't really tell a Google Pixel with 3.1 (2649), but I think I see it too.

shanaqui avatar Nov 23 '20 11:11 shanaqui

will talk with phillip whether its easier to add padding to the grid or extend the reward

saraolson avatar Nov 23 '20 15:11 saraolson

This one unfortunately isn't as easy to fix, as the spacing between the sides and the item cards depends on the devices width. So we'd need to figure out that spacing somehow, so that we can then use it for the custom rewards.

phillipthelen avatar Jan 25 '21 16:01 phillipthelen

@phillipthelen is there not a set amount of padding on each side of the screen for item grids that we could increase to match the custom reward?

saraolson avatar Jan 25 '21 21:01 saraolson

In the meantime, is it ok to work on this or at least take a look?

cdmunoz avatar Mar 12 '21 02:03 cdmunoz

@cdmunoz you're welcome to take a look! the desired fix would be to add extra padding to the edges of the item grid, and leave the task padding as is.

saraolson avatar Mar 15 '21 14:03 saraolson