Roman Zabaluev

Implications of using api secrets in a public environment?

1

Hi, more of a question actually, rather than an issue. Couldn't find the answer to my question anywhere else so decided to raise one here. As stated in README, running...

`GHEventPayload` should not contain `repository` as a root level property

1

Probly a candidate for a breaking change for v2: `GHEventPayload` probably should not contain `repository` as a root level property as it might not be present in every webhook payload....

Convert methods with checked exceptions to unchecked (support streaming and functional programming)

20

Hi, `GHObject#getCreatedAt` and `GHObject#getUpdatedAt` throw unnecessary `IOException` which is not being thrown by an underlying code. Is there a reason for this?

Bug: Do not try to populate a repo on Installation:deleted event

1

Hi, there is an issue in case of trying to parse event payload of type Installation ("deleted"): The installation at this point has been deleted so fetching repo info is...

Unable to mock GHObject#id

10

Hi, it seems like it's impossible to mock `GHObject` via Mockito, I observe this behavior: ``` try { var a = Mockito.mock(GHObject.class); when(a.getId()).thenReturn(123L); } catch (Throwable e) { e.printStackTrace(); }...

Do not populate repo list in case of installation:deleted event

3

# Description Closes #1689 That's a proposition of a solution I came up with. Unfortunately I haven't been able to run the whole test suite due to the same repeating...

Meta: Consider squash merges instead of rebase

1

Hi! Just a minor issue I've observed while scanning the git log, it seems that current PR merges into the master are being done via rebase strategy. I wanted to...

Reattaching an entity to another client instance

4

Hi, I've got a situation like this: 1. My app does listen to incoming webhooks, I parse the payload with an instance of a client authenticated **as an app** with...

Enhancement: ParseEventPayload: Parse the event type automatically

1

Hi, I noticed the following documentation on `GitHub#parseEventPayload`: ``` [...] Unfortunately, hook script payloads aren't self-descriptive, so you need to know the type of payload you are expecting. ``` As...

Support Github Apps API

1

Hi, there seems to be no support for Github App's API. Docs could be found [here](https://docs.github.com/en/rest/apps/apps?apiVersion=2022-11-28#list-installation-requests-for-the-authenticated-app). [The other](https://github-api.kohsuke.org/) existing GH API library does support this, I guess it could be...