almanac.httparchive.org icon indicating copy to clipboard operation
almanac.httparchive.org copied to clipboard
verified publisher icon HTTPArchive

Media 2024 queries

Open stefanjudis opened this issue 1 year ago • 4 comments

This PR includes the updated queries for the media chapter. #3596

stefanjudis avatar Aug 17 '24 17:08 stefanjudis

How do you get around the of blocked regex 'TABLESAMPLE' error? I don't actually know what it does mind you...

mgifford avatar Aug 26 '24 17:08 mgifford

@mgifford I'm sorry, I don't understand. What error?

stefanjudis avatar Aug 26 '24 17:08 stefanjudis

TABLESAMPLE SYSTEM (0.001 PERCENT) says only run this on 0.001% of the rows in the table. This is good during query development as faster (and cheaper!) to run than on the full dataset.

However, eventually we will want all queries run on the full dataset. Therefore there is a linting rule warning this is being used and we should not merge this PR until that is fixed.

So it's fine to ignore it for now (especially as this PR is still in Draft status) if you're still working on those queries. It just means you won't see a nice green tick in the linting check for now and also that you might miss other linting errors unless you explicitly look at those checks to see if anything else needs fixing too.

tunetheweb avatar Aug 26 '24 18:08 tunetheweb

Aaaah, I didn't realize there was a linting error. Thanks @tunetheweb!

I've run most of the queries against the full data set already. and will double check that this is true!

stefanjudis avatar Aug 26 '24 18:08 stefanjudis

I've been writing off of the results of these - as far as I can tell they are good to merge!

eeeps avatar Nov 09 '24 08:11 eeeps