digitransit-ui icon indicating copy to clipboard operation
digitransit-ui copied to clipboard

yarn resolution warnings

Open hbruch opened this issue 2 years ago • 4 comments

yarn run setup currently reports various warnings in the resolution step. They can be grouped in the following categories:

  1. missing peerDependencies (YN0002) in digitransit-ui or digitransit-ui-components
  2. missing peerDependencies (YN0002) in hsl components
  3. missing peerDependencies (YN0002) in third party components
  4. not-satisfying versions provided (YN0060)

I suggest the following actions to resolve these warnings:

  1. fix declared peerDependencies in digitransit-ui or digitransit-ui-components
  2. fix declared peerDependencies in hsl-fi packages and upgrade digitransit-ui to updated versions
  3. As temporary fix, add missing peerDependencies as packageExtensions to .yarnrc.yml and mid-term upgrade concerned packages (assuming they are fixed in the meantime, otherwise suggest fixes there)
  4. check and correct versions. IMHO most clashes are caused by fixed versions in package.json, where rather ranges should be specified.

hbruch avatar Feb 13 '23 09:02 hbruch

I'll provide a PR for 1., 3. and 4. @vesameskanen could anyone from HSL address the hsl-fi changes? Otherwise I'd add (at least temporarilly) packageExtensions.

hbruch avatar Feb 13 '23 10:02 hbruch

I can try to fix hsl.fi related warnings.

vesameskanen avatar Feb 13 '23 10:02 vesameskanen

I wonder what is the proper fix for workspace related warnings. For example, all sub components of digitransit-component library give a warning that digitransit-component does not provide i18next, but I guess that is intentional. The mentioned library is provided by the root package.json.

vesameskanen avatar Feb 13 '23 11:02 vesameskanen

peerDeependencies need to be defined not only on the top-level project, but by it's components as well. #4751 fixes these.

hbruch avatar Feb 15 '23 11:02 hbruch