phoenix
phoenix copied to clipboard
Upgrading to tween.js 25.0.0 breaks zoom
As per description - if we do this, the zoom buttons no longer work.
Hey @EdwardMoyse , could you please elaborate the issue... Do you want to disable and remove the zooming functionality? I can do it if that is the requirement.
Hi @EdwardMoyse, I've addressed the zoom breakage caused by upgrading to tween.js v25.0.0. Summary of Changes that i did:
- Upgraded tween.js from 23.1.3 to 25.0.0 in package.json
- Refactored tween usage across:
- ThreeManager: introduced Group, initialized tweenGroup, updated all Tween and update() calls
- ControlsManager: passed tweenGroup via constructor, updated zoom tween
- AnimationsManager: updated 8 tween instances to use tweenGroup
These are the Key Fixes: tween.js@25 requires explicit group management:
- Before: new Tween(object) auto-registered globally
- After: new Tween(object, group) must be manually managed via Group.update() Zoom buttons now work as expected with the new tween lifecycle.
Please let me know!
Sorry @harshrajsoni I completely missed this. Did you make a pull request? If not, please do so!