phoenix icon indicating copy to clipboard operation
phoenix copied to clipboard

Upgrading to tween.js 25.0.0 breaks zoom

Open EdwardMoyse opened this issue 1 year ago • 2 comments

As per description - if we do this, the zoom buttons no longer work.

EdwardMoyse avatar Sep 03 '24 13:09 EdwardMoyse

Hey @EdwardMoyse , could you please elaborate the issue... Do you want to disable and remove the zooming functionality? I can do it if that is the requirement.

nidhaahmed avatar Dec 21 '24 00:12 nidhaahmed

Hi @EdwardMoyse, I've addressed the zoom breakage caused by upgrading to tween.js v25.0.0. Summary of Changes that i did:

  • Upgraded tween.js from 23.1.3 to 25.0.0 in package.json
  • Refactored tween usage across:
  • ThreeManager: introduced Group, initialized tweenGroup, updated all Tween and update() calls
  • ControlsManager: passed tweenGroup via constructor, updated zoom tween
  • AnimationsManager: updated 8 tween instances to use tweenGroup

These are the Key Fixes: tween.js@25 requires explicit group management:

  • Before: new Tween(object) auto-registered globally
  • After: new Tween(object, group) must be manually managed via Group.update() Zoom buttons now work as expected with the new tween lifecycle.

Please let me know!

harshrajsoni avatar Nov 01 '25 11:11 harshrajsoni

Sorry @harshrajsoni I completely missed this. Did you make a pull request? If not, please do so!

EdwardMoyse avatar Dec 07 '25 15:12 EdwardMoyse