HSF
Order better the Collections info dropdown
When we open the Collections Info windows, the collections dropdown is currently unsorted. See below.
What would be ideal is to divide it into different types of collections. Or we add another dropdown to select the type, with this dropdown then only showing collections of the requested type.
If all of this is too hard (or as a stopgap) we should at least sort it alphabetically.
Hi i would like to resolve the issue , so can you help me on how can i replicate the situation.
Hi @Krrish-29 - that would be great! Firstly, you need to check out and run Phoenix locally: https://github.com/HSF/phoenix/blob/main/CONTRIBUTING.md (please let us know if anything is incorrect/unclear in the documentation? It has been a while since we last did a review)
Secondly, navigate to the ATLAS example, and open the collections tab:
This popup is the "collections info overlay": https://github.com/HSF/phoenix/tree/main/packages/phoenix-ng/projects/phoenix-ui-components/lib/components/ui-menu/collections-info/collections-info-overlay
In PhoenixLoader::getCollection you can see that the event data is sorted into "ObjectTypes" ... I don't think we have an easy way to get this yet in the GUI. Probably the best/easiest is to modify getCollections to return the types, instead of just the names... i.e. return a dictionary with the type as the key, and the collection names as the payload.
hello, I would like to work on this issue, How exactly do you want it sorted, alphabetically or by type?
By type is more important than alphabetical (but my by type first, then alphabetical?)
On Fri, 13 Dec 2024 at 14:04, Pratham @.***> wrote:
hello, I would like to work on this issue, How exactly do you want it sorted, alphabetically or by type?
— Reply to this email directly, view it on GitHub https://github.com/HSF/phoenix/issues/567#issuecomment-2541421258, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTTQSJ2F3SQMUJTTDGDS632FLLPJAVCNFSM6AAAAABRP6WCJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBRGQZDCMRVHA . You are receiving this because you authored the thread.Message ID: @.***>
See this comment:
In PhoenixLoader::getCollection you can see that the event data is sorted into "ObjectTypes" ... I don't think we have an easy way to get this yet in the GUI. Probably the best/easiest is to modify getCollections to return the types, instead of just the names... i.e. return a dictionary with the type as the key, and the collection names as the payload.
Is this fine?
I updated the getCollections function in pheonixloader to return a dictionary with type as key and collection names as payload then changed teh html file and ngOnInit hook.
Ok I came back to this issue, wanted to ask a question - Can I change the phoenix-loader.test and the collections-info-overlay.component.test.ts as thats where my code is breaking the CI - since ive changed the getCollections function in phoenix-loader.ts I will have to change parts of the tests.
Oh sorry! I thought I replied ages ago - yes, you definitely need to modify these files and you should feel free to do so.