phoenix icon indicating copy to clipboard operation
phoenix copied to clipboard
verified publisher icon HSF

Commit conventions and releases

Open 9inpachi opened this issue 3 years ago • 3 comments

I think we need to rethink our commit conventions. Our release notes have duplicated commits in them. See https://github.com/HSF/phoenix/releases/tag/v2.7.0

One recommendation I have is to not use the conventions for ordinary commits but only for when we merge a pull request to master. We already have a workflow where each feature is merged through a pull request, so it should work.

CC: @EdwardMoyse

9inpachi avatar Apr 23 '22 09:04 9inpachi

This sounds like a good idea to me! I just tried it with the MR I accepted on Wednesday: https://github.com/HSF/phoenix/commit/ff9f733300bfbbc16ce79b365c0cdf5c534f871d

EdwardMoyse avatar May 06 '22 10:05 EdwardMoyse

With our latest release, I found that merge commits are not included in the CHANGELOG. This is problematic. Maybe we should configure our changelog to use PRs for release notes instead.

9inpachi avatar May 17 '22 20:05 9inpachi

An option for PR-based changelog: https://github.com/lerna/lerna-changelog

9inpachi avatar Jun 02 '22 18:06 9inpachi