hms-react-native-plugin icon indicating copy to clipboard operation
hms-react-native-plugin copied to clipboard

Update react dependency

Open peltax opened this issue 3 years ago • 3 comments

Hello, react dependency is hardcoded to 16.x in package.json. This prevents npm installation without "--legacy-peer-deps" flag if one is using newer react-native such as 0.64, that uses react 17.x. Please update all react-native npm packages to allow other react versions.

npm i @hmscore/react-native-hms-availability npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! While resolving: [email protected] npm ERR! Found: [email protected] npm ERR! node_modules/react npm ERR! react@"17.0.1" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer react@"^16.6.0" from @hmscore/[email protected] npm ERR! node_modules/@hmscore/react-native-hms-availability npm ERR! @hmscore/react-native-hms-availability@"*" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force, or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

peltax avatar Oct 28 '21 07:10 peltax

Is there plans to go for a bugfix triage?

peltax avatar Mar 23 '22 12:03 peltax

Hi @peltax ,

We have tested our plugins with the latest version of React Native. The problem occurs when npm version is greater than 6. We advise you to change your node version to 14.

If the issue persists, please feel free to contact us. Thank you for helping us to improve our plugins.

UgurBas avatar May 31 '22 09:05 UgurBas

I am using node version 18.2.0 and same here. ( RN 0.66 ) Can't do npm install with "--legacy-peer-deps" flag.

However, using yarn is fine.

tarouboy avatar Jun 06 '22 10:06 tarouboy