HMCL icon indicating copy to clipboard operation
HMCL copied to clipboard

修复 #3099 自动安装选项卡重新选择版本(Minecraft版本和模组加载器版本)的按钮消失的问题

Open burningtnt opened this issue 1 year ago • 9 comments

Fix #3099 Fix #3144 Fix #3164

burningtnt avatar Jun 13 '24 15:06 burningtnt

重构了相关代码,需要社区深入测试。

burningtnt avatar Jun 13 '24 15:06 burningtnt

How about changing the second half to the version number of the currently installed game?

Good idea! I've implementated it.

burningtnt avatar Jun 23 '24 10:06 burningtnt

It is still the same place.

Three problems with it:

  • The button for switching versions of the modloader does not work
  • The user interface is a bit misplaced
    • When no modloader is selected, the Minecraft icon and text are positioned differently than the others
    • After selecting any modloader, the user interface changes a bit strangely, deselecting the modloader will restore it to its original state
  • The Filename in the upper left corner does not look very good
    • This seems to refer to the i18n key archive.name, where several language files appear similar to English (esp. Spanish and Russian)
    • Could we consider creating a new i18n key? I recommend using a simple and concise Name
Preview

3gf8jv4dv avatar Jun 23 '24 12:06 3gf8jv4dv

The button for switching versions of the modloader does not work

Fixed.

The user interface is a bit misplaced

I've made the height of each mod loader pane be set to 0.75 * width. It's a bad implementation but it works :)

burningtnt avatar Jun 23 '24 13:06 burningtnt

The icon is still misaligned. This also exists in the current main branch. Is there a way to fix it?

Preview

3gf8jv4dv avatar Jun 23 '24 13:06 3gf8jv4dv

The icon is still misaligned. This also exists in the current main branch. Is there a way to fix it?

This is NOT a implementation problem. The key is how to layout these elements, as some of the mod loader panes contains button, and some of them contains version number.

burningtnt avatar Jun 23 '24 13:06 burningtnt

image It's 'Instance Name' and '版本名称' now.

burningtnt avatar Jun 23 '24 13:06 burningtnt

This is NOT a implementation problem. The key is how to layout these elements, as some of the mod loader panes contains button, and some of them contains version number.

Got it.

It's 'Instance Name' and '版本名称' now.

Looks good.

3gf8jv4dv avatar Jun 23 '24 13:06 3gf8jv4dv

This is NOT a implementation problem. The key is how to layout these elements, as some of the mod loader panes contains button, and some of them contains version number.

I have once considered putting the buttons to right of this pane and keeping others in the center. But that will make this page uglier.

burningtnt avatar Jun 23 '24 13:06 burningtnt