HMCL icon indicating copy to clipboard operation
HMCL copied to clipboard

修复自动安装在新版本各大组件的 Breaking Change 下会各种爆炸的问题

Open burningtnt opened this issue 1 year ago • 7 comments

Close #2975 Close #3021

burningtnt avatar May 03 '24 14:05 burningtnt

做的差不多了,需要社区帮助测试

burningtnt avatar May 05 '24 02:05 burningtnt

Forge 做了更改,需要处理兼容性,将更改代码逻辑

burningtnt avatar May 10 '24 01:05 burningtnt

Good. Thanks for your detailed testing.

burningtnt avatar May 11 '24 00:05 burningtnt

By the way, may you try installing forge + optifine with the main branch, and launch the game with this PR. I've made some codes to automatically fix the optifine installed by legacy version.

burningtnt avatar May 11 '24 00:05 burningtnt

By the way, may you try installing forge + optifine with the main branch, and launch the game with this PR. I've made some codes to automatically fix the optifine installed by legacy version.

If I understand correctly: I tried installing Forge 49.0.31/49.0.49 and OptiFine HD_U_I8_pre4 on a build from the main branch, then closed and opened this PR build to launch the game directly.

But the game did not launch successfully. I checked the library file and found that the mods.toml in the OptiFine related files was not deleted. Removed and reinstalled OptiFine in the Modloaders / OptiFine interface using a PR build and the game ran as expected.

3gf8jv4dv avatar May 11 '24 04:05 3gf8jv4dv

By the way, may you try installing forge + optifine with the main branch, and launch the game with this PR. I've made some codes to automatically fix the optifine installed by legacy version.

If I understand correctly: I tried installing Forge 49.0.31/49.0.49 and OptiFine HD_U_I8_pre4 on a build from the main branch, then closed and opened this PR build to launch the game directly.

But the game did not launch successfully. I checked the library file and found that the mods.toml in the OptiFine related files was not deleted. Removed and reinstalled OptiFine in the Modloaders / OptiFine interface using a PR build and the game ran as expected.

可能是因为删除 mods.toml 是在安装 optifine 的时候

zkitefly avatar May 11 '24 06:05 zkitefly

可能是因为删除 mods.toml 是在安装 optifine 的时候

I've made some changes to check OptiFine while checking whether the game is conplete. Maybe there's a bug here.

burningtnt avatar May 11 '24 06:05 burningtnt

Has been fixed yesterday but I forgot to send a messsage. There should NOT be any bugs. (?)

burningtnt avatar May 16 '24 11:05 burningtnt

Has been fixed yesterday but I forgot to send a messsage. There should NOT be any bugs. (?)

I saw the commit you pushed earlier, but I was dealing with other things at the time. I will test it later.

3gf8jv4dv avatar May 16 '24 13:05 3gf8jv4dv

Tested using release-3.5.8 (release) and a build based on https://github.com/burningtnt/HMCL/commit/200cc50d20dc3e845e54edcf8da892edf9473d27.

Builds based on this PR now correctly fix OptiFine library files under Forge & OptiFine instances for 1.20.4 installed through a launcher that does not contain this PR.

3gf8jv4dv avatar May 16 '24 13:05 3gf8jv4dv