HMCL icon indicating copy to clipboard operation
HMCL copied to clipboard

Published 20 hours ago • verified publisher icon HMCL-dev

[Bug] In version 22w45a+, selecting the Steve/Alex skin before launching the game results in the wrong skin

Open 3gf8jv4dv opened this issue 1 year ago • 6 comments

平台 | Platform

Windows 11

问题描述 | Problem Description

Commit: https://github.com/HMCL-dev/HMCL/commit/59cc5b9114153def6668317631f6aa85a20676ff

  1. Add an account
  2. Select the Steve or Alex skin in the Upload Skin interface
  3. Add an instance with game versions 22w45a+
  4. Start the instance and you will find that the skin may be different

I guess it has something to do with Mojang adding new default skins in 22w45a. Java Edition 22w45a – Minecraft Wiki

The test results are shown below: https://github.com/HMCL-dev/HMCL/issues/2784#issuecomment-1938448761

Using Local Skin File and LittleSkin does not seem to be affected. Blessing Skin is not tested.

启动器崩溃报告 / 启动器日志文件 | Launcher Crash Report / Launcher Log File

3gf8jv4dv avatar Feb 12 '24 08:02 3gf8jv4dv

HMCL hasn't fully support to change you skin on offline accounts in these Minercraft versions.

burningtnt avatar Feb 12 '24 08:02 burningtnt

I tested it with 1.19.3 and it is indeed Alex skinned!

2024-02-12_17 18 08

Probably only the beta version has this problem

zkitefly avatar Feb 12 '24 09:02 zkitefly

Is this issue caused by the comparator of Game Version? Could you test with the PR Collection version, as it contains PR #2700

burningtnt avatar Feb 12 '24 09:02 burningtnt

@burningtnt I’ll do it right away.

3gf8jv4dv avatar Feb 12 '24 09:02 3gf8jv4dv

@burningtnt @zkitefly

My wording was inappropriate and too one-sided before. I apologize for this. I added 3 offline accounts with different usernames and tested using 22w45a and 1.20.4. Commit: https://github.com/burningtnt/HMCL/commit/67d01220453e185cbd08724d1e85200e1aa74eca

In the picture, the one on the left is the game version, the one in the middle is the username, and the one on the right is the skin type.

22w45a:

Details

1-1

1-2

1-3

1-4

1-5

1-6

1-7

1-8

1-9

1.20.4:

Details

2-1

2-2

2-3

2-4

2-5

2-6

2-7

2-8

2-9

3gf8jv4dv avatar Feb 12 '24 10:02 3gf8jv4dv

Thank you so much! I will check the codes and try to fix this.

burningtnt avatar Feb 12 '24 11:02 burningtnt

The prediction from the UUID to a default skin hasn't support such Minecraft version. Therefore, when HMCL thought the UUID would provides Steve and doesn't launch a authlib-injector service, The skin calculated by Minecraft comes to another skin.

We will fix this bug later. As this is not a big problem, so it would not be traced in #2925.

burningtnt avatar Mar 14 '24 12:03 burningtnt