Henrique Silvério

Results 38 comments of Henrique Silvério

> As specified in https://google.github.io/styleguide/pyguide.html#doc-function-raises. > > Only two functions (in `simresults.py`) currently have such a section, whereas so many of them can raise Errors. @LaurentAjdnik , note the last...

> BTW, shouldn't we add https://pypi.org/project/flake8-docstrings/ to CI ? > > I tested it locally and the results were... kinda wild... This is a great idea, though it needs some...

Strictly speaking you're right. Every time we raise a ValueError because a value is, for example, out of range, and we did not specify this range in the docstring, then...

@LaurentAjdnik is it okay if I close this issue?

> @HGSilveri: Shall we open this specific issue? I agree there would be some (= a lot of?...) fine-tuning before the results are satisfying. @LaurentAjdnik Actually, I already took care...

I'm with @lvignoli - I like the cleanliness of option 1., but I don't think it's worth the potential for confusion. I would go with 3. too. My only qualm...

@sebgrijalva This issue has been open for a while now, what's the status on this? Should we close it / archive it?

The construction of the `Sequence` class has since changed to store every relevant call that is made in its construction. As such, a device switch can instead be achieved by...

Great @Varda-star , it's yours!

Hi @Varda-star , that's I would go about it too, I agree with this approach. Still, don't forget that there is no requirement on the channels of the device having...