hexrdgui icon indicating copy to clipboard operation
hexrdgui copied to clipboard

Feature suggestion for refinements

Open akrygier opened this issue 1 year ago • 4 comments

It would save time to be able to add a button or equivalent to select and deselect all tilts and all translations for the image plates in the tree view of the instrument panel.

PXRDIP has 5 image plates and it's a lot of scrolling and clicking etc.

akrygier avatar Jun 09 '23 16:06 akrygier

@akrygier Here's something that might help:

  1. Can you navigate to Edit->Refinements? This opens up a more thorough refinements editor.
  2. Then, for the first detector, check all tilts and translations.
  3. Then in the refinements actions near the bottom, select "Mirror first detector", then click "Apply Action".

This will copy the refinements selections to all detectors after the first one.

We have been thinking to make that refinements editor the recommended way to select refinements. I've set it up so we can easily add "Refinements Actions", like we could easily add one that says "Select All Detector Transforms", and that would select all tilts/translations.

psavery avatar Jun 09 '23 16:06 psavery

Ahh ok, I see that. That makes sense.

I think it would be best to have options like that only in one place.

For PXRDIP, I have been just doing the translations first since selecting both tilts/translations sometimes results in the image plates rotating around the azimuth to clearly incorrect locations (ie, edges of image plates overlapping each other).

If it's useful, the workflow I use is:

  1. translations
  2. x-ray source polar_angle + translations
  3. tilts + x-ray source polar_angle + translations

I imagine the optimal approach is probably dependent on individual datasets.

akrygier avatar Jun 09 '23 22:06 akrygier

That's the workflow I use for most of TARDIS datasets as well.

saransh13 avatar Jun 09 '23 23:06 saransh13

Ahh ok, I see that. That makes sense.

I think it would be best to have options like that only in one place.

Should we think about getting rid of the refinement options in the instrument config tree view, so that the refinement options are only in one place (the "Refinements Editor")?

I would be in favor of that.

It may also be beneficial for us to do like we did for the structureless calibration, and have the refinement options displayed right there as you run it.

psavery avatar Jun 27 '23 18:06 psavery