hexrd icon indicating copy to clipboard operation
hexrd copied to clipboard

Gvec xy test

Open donald-e-boyce opened this issue 1 year ago • 1 comments

This is a work in progress. It adds several groups of tests for gvec_to_xy could easily be extended to test xy_to_gvec. The tests in include varying beam direction, theta and eta angles, translation vectors, detector orientation, sample and crystal orientations.

It also includes tests that should return nans, but these are inactivated due to Issue #704.

donald-e-boyce avatar Aug 12 '24 19:08 donald-e-boyce

Hello @donald-e-boyce! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 63:11: E251 unexpected spaces around keyword / parameter equals Line 63:13: E251 unexpected spaces around keyword / parameter equals

Comment last updated at 2024-09-04 16:16:26 UTC

pep8speaks avatar Aug 12 '24 19:08 pep8speaks