FCCAnalyses icon indicating copy to clipboard operation
FCCAnalyses copied to clipboard

addons headers are not properly installed

Open tmadlener opened this issue 3 years ago • 1 comments

I ran into this because EDM4hep seems to try and pick up the shared libraries/dictionaries that are built by FCCAnalyses in CI: https://github.com/key4hep/EDM4hep/actions/runs/3468331195/jobs/5794042094#step:4:589

The problem seems to be that the FastJet/JetClustering.h is not installed. I didn't yet check very thoroughly, but it seems that none of the header files in the addons/FastJet folder are installed to prefix/include.

tmadlener avatar Nov 15 '22 11:11 tmadlener

Also the CMake config needs adaptation most likely: https://github.com/HEP-FCC/FCCAnalyses/blob/8ce567fdf79e4a78d0f389dfa984aeabb596c154/analyzers/dataframe/CMakeLists.txt#L42

Alternatively if these are private headers, they should be declared as such (and removed from the public headers)

tmadlener avatar Nov 15 '22 12:11 tmadlener