aiodynamo icon indicating copy to clipboard operation
aiodynamo copied to clipboard

Faster release cycle

Open jarikujansuu opened this issue 4 years ago • 10 comments

Not sure if this is correct channel for this kind of request.

But I wish there was faster release cycle, currently of course interested in having released version which would include https://github.com/HENNGE/aiodynamo/pull/101. Last release has been October 7th and after that has been 2 functional improvement PRs, and that consistent read support was merged 23 days ago.

I am now using git dependency but as there are also no tags have to rely on random rev value which is not obviously clear what we are using.

jarikujansuu avatar Nov 12 '21 09:11 jarikujansuu

@ojii WDYT about giving Jari pypi privileges?

dimaqq avatar Nov 12 '21 09:11 dimaqq

Why not setup deploy flow to pypi in github actions when merging to master?

tedchou12 avatar Nov 12 '21 09:11 tedchou12

I'd prefer automated releases as ted suggests, but I've never set that up so I'm not sure what the current state of the art is. if someone knows, please let me know.

ojii avatar Nov 15 '21 01:11 ojii

@ojii It seems like there is no setup.py file in the repo. I can set it up. Could you help me with the following?

  1. Put a pypi api token under the secrets of this repo.

I can do the rest.

tedchou12 avatar Nov 15 '21 13:11 tedchou12

We use poetry

dimaqq avatar Nov 16 '21 00:11 dimaqq

Manually I'd do poetry build and then poetry publish … I can’t recall if the latter asks for credentials or need them in advance.

dimaqq avatar Nov 16 '21 00:11 dimaqq

Just briefly reading looking at: https://python-poetry.org/docs/repositories/

Poetry authenticates with pypi via poetry config ..., so you probably have preconfigured it before at some point?

I think this the steps in this article makes sense: https://dev.to/iancleary/test-and-publish-a-python-package-to-pypi-using-poetry-and-github-actions-186a

In that case, to upload to pypi still needs a pypi token. Screen Shot 2021-11-16 at 9 24 27

tedchou12 avatar Nov 16 '21 00:11 tedchou12

Manually I'd do poetry build and then poetry publish

huh I still use twine upload am I doing things wrong?

ojii avatar Nov 16 '21 01:11 ojii

@jarikujansuu while we're trying to figure out how to automate/improve this, I've released 21.11.

ojii avatar Nov 16 '21 01:11 ojii

Dima is right, poetry doesn't require twine upload. But pypi credentials are still needed.

I tried it a few times with pypi-test, seems to be working fine. https://github.com/HENNGE/aiodynamo/pull/106

tedchou12 avatar Nov 16 '21 08:11 tedchou12