docnado icon indicating copy to clipboard operation
docnado copied to clipboard

Mobile theme issues

Open refi64 opened this issue 5 years ago • 3 comments

There were two issues I noticed on mobile:

  • Opening the sidebar breaks the layout: Screenshot_20190915-211954

  • Even with it closed, YouTube videos don't scale: Screenshot_20190915-212014

refi64 avatar Sep 16 '19 02:09 refi64

Code blocks also don't scale:

Screenshot_20190915-212419

refi64 avatar Sep 16 '19 02:09 refi64

Thanks for the issue report! Do you know what css we need to change in order to fix it?

JohnHardy avatar Sep 27 '19 10:09 JohnHardy

For the first problem, IMO the mobile site looks better if you drop the margin-left off of page-main on mobile, which also "fixes" this issue. (The margins are also a bit wide, on mobile e.g. 44px would look a lot better. Right now, the content is rather thin.)

For the code blocks, overflow properties interact weirdly with flexbox, so the TL;DR is that you need to set min-width: 0 on your page-content element, which seems to pretty much magically fix all the code block scroll bars. This also "fixes" the video; it ends up weirdly thin, but you can work around that by dropping your custom width and height settings on its iframe. You could probably use media queries to only set a width if the display is big enough to fit it.

refi64 avatar Sep 30 '19 01:09 refi64