Hans Dembinski

Results 330 comments of Hans Dembinski

> We need a roughly feature complete version (1.0), and then we can drop Python 2 support. Why do we need that? Only because you wrote it in a plan?

https://github.com/boostorg/histogram/pull/364 is not really related to this. I am just making some internal tool easier to use, this does not have an external effect.

I think it would be very useful to support filling with awkward arrays if that can be achieved without introducing a dependency on awkward. `fill()` could check whether `to_numpy()` exists...

For what exactly do you need unsafe access to the storage? What kind of tasks do you want to do which are not possible with the public API? Your code...

Ok, thanks for the additional detail. Have you tried to use `indexed` to add histograms of different sizes? It should be faster than using `fill_n`. If you use the non-public...

I don't think that `.clear` would be any more obvious than `.reset`. Important is the documentation, not the name.

Hi @gohil-jay , great progress! I added new comments. I think the next step for you is to write some unit tests. The tests are located in the folder tests....

Most of the tests are failing, because I made a mistake, I am fixing that now.

Please merge the develop branch into this one to get the fix that I just commited. In the terminal, do `git merge develop` when the currently active checkout is your...

Edit: This has been fixed (temporarily?) by fixing the types of the helper functions to double, so can be regarded as resolved. I didn't find a nice way of fixing...