ATMSeer
ATMSeer copied to clipboard
<fix> docker installation cannot execute in China mainland
For any question, please contact: QQ/Wechat: 506680965 E-mail: [email protected]
Hello, thanks for the PR.
It seems that you were having trouble installing in China mainland? Can you please report an issue first with the problem you were having? This will also help anyone else with the same problem find your solution.
It looks like you have fixed the problem by overwriting source URLs with China-specific URLs. While this may have solved your problem, if we merge your PR it would mean that all users globally who try to install ATMSeer would be using China-specific URLs. This is not a good solution, as sources like ubuntu.com and pypi.org are canonical.
Perhaps you would like to create an alternative Dockerfile, say Dockerfile-cn
? And modify docker-compose.yml
to use an environment variable for the dockerfile that defaults to Dockerfile but can be configured to another one? Other solutions that maintain the existing behavior for most users but allow customization for users in China would be welcomed.