hermes icon indicating copy to clipboard operation
hermes copied to clipboard

Rename TestWriteDataset() to TestMakeDataset() in hermes/adapter/test/vfd/hermes_vfd_test.cc.

Open hyoklee opened this issue 3 years ago • 2 comments

Function naming is not consistent.

void TestWriteDataset(const std::string &dset_name,
                      const std::vector<f32> &data) {
  Hdf5Api api;
  api.MakeDataset(test::hermes_hid, dset_name, data);
  api.MakeDataset(test::sec2_hid, dset_name, data);
}

void TestMakeCompactDataset(const std::string &dset_name,
                            const std::vector<f32> &data) {
  Hdf5Api api;
  api.MakeDataset(test::hermes_hid, dset_name, data, true);
  api.MakeDataset(test::sec2_hid, dset_name, data, true);
}

hyoklee avatar Oct 20 '22 20:10 hyoklee

Also, remove unused structure members.

hyoklee avatar Oct 20 '22 21:10 hyoklee

Unused members are commented out by PR #467 but they need to be removed once @lukemartinlogan approves.

hyoklee avatar Nov 03 '22 17:11 hyoklee