hermes
hermes copied to clipboard
Rename TestWriteDataset() to TestMakeDataset() in hermes/adapter/test/vfd/hermes_vfd_test.cc.
Function naming is not consistent.
void TestWriteDataset(const std::string &dset_name,
const std::vector<f32> &data) {
Hdf5Api api;
api.MakeDataset(test::hermes_hid, dset_name, data);
api.MakeDataset(test::sec2_hid, dset_name, data);
}
void TestMakeCompactDataset(const std::string &dset_name,
const std::vector<f32> &data) {
Hdf5Api api;
api.MakeDataset(test::hermes_hid, dset_name, data, true);
api.MakeDataset(test::sec2_hid, dset_name, data, true);
}
Also, remove unused structure members.
Unused members are commented out by PR #467 but they need to be removed once @lukemartinlogan approves.