HDFGroup
file_offset_t < size_t on mingw
Describe the bug Using the mingw toolchain we encounter a problem in the assertation on the following https://github.com/HDFGroup/hdf5/blob/ac07382ca947de2b936204dc9d60ce9ac245a21f/src/H5FDstdio.c#L354 which crashes the program
Expected behavior The assertation to not trigger a crash.
Platform
- Default windows github runner
- HDF5 version 1.14.1-2 from source
- Microsoft Windows Server 2022
- Mingw-w64 11.2.0
- CMake 3.26.4
Additional context
- A build log can be found here https://github.com/aldanor/hdf5-rust/actions/runs/5225628766/jobs/9435350340?pr=243
- Found when trying to use 1.14.1 in
hdf5-rust
We don't have great testing for MinGW, but I would like to get that set up as a GitHub action ASAP so we can fix these issues.
@derobins mingw builds are very easy to set up on github actions (you can check hdf5-rust CI as an example).
Would really appreciate if this was looked into since it's currently a blocker for us bundling 1.14 for static builds.
@aldanor and/or @mulimoen - shoot me an email at derobins at hdfgroup dot org and we'll get this fixed.
Is this still a problem? We build and test MinGW in several environments now and we don't see this assert being tripped.
We still see the problem: https://github.com/mulimoen/hdf5-rust/actions/runs/11579804898/job/32236915194
Let me know if this PR fixes the problem. It should be merged in the next day or so.
https://github.com/HDFGroup/hdf5/pull/5064
Update: It's in. Let me know if this fixes your problem!
Hi @mulimoen @aldanor I just want to draw your attention to derobins's message on Nov 3, 2024. Please let us know if this issue can be closed. Thanks!
Was this fix included in 1.14.6, as the problem is still present there: https://github.com/metno/hdf5-rust/actions/runs/16470318613/job/46557649259?pr=88#step:5:220
