HDF.PInvoke
HDF.PInvoke copied to clipboard
GetDllPathFromAppConfig Not Considering Existing Keys
If a program has keys specified in its config file that is NOT "NativeDependenciesAbsolutePath", then a NullReferenceException occurs on line 31 in NativeDependencies.cs where it attempts to get the path.
A null check should be added for the NativePathString key before attempting to get the value.
In the short term, I can clone and make the change locally, but this should be officially fixed and released.
This is a blocking issue for me.
Is HDF.PInvoke.1.10 working for you? It uses as different library resolution process.
Unfortunately, I can't use 1.10 right now since we are using 1.8 when writing results. We're hoping to move to 1.10 at some point down the road.
I have the fix locally and I can use that build for the time being, but it would be nice to use an official build of the library rather than building it locally.
@gheber, would you accept a PR fixing this and publish a patch release on Nuget?
If yes, @MrMontana1889 , could you please create a PR?
@MrMontana1889. I'm pretty sure version 1.10 saves by default in 1.8 format so using 1.10 should work fine for you. You can override this behaviour using set_libver_bounds.
@MrMontana1889. I'm pretty sure version 1.10 saves by default in 1.8 format so using 1.10 should work fine for you. You can override this behaviour using set_libver_bounds.
Yes.
@gheber, would you accept a PR fixing this and publish a patch release on Nuget?
If yes, @MrMontana1889 , could you please create a PR?
Yes.
I'll give it a shot tomorrow.