puncover icon indicating copy to clipboard operation
puncover copied to clipboard

Add parameter to include source code in the disassembly

Open awujek opened this issue 3 years ago • 4 comments

Signed-off-by: Adam Wujek [email protected]

awujek avatar Mar 02 '21 13:03 awujek

can be considered as related to #21

awujek avatar Mar 02 '21 13:03 awujek

Thank you, @awujek !

Do you think the default should be True instead of the picked False?

Also, could you do me a favour and add a test similar to https://github.com/HBehrens/puncover/blob/706dcc5e4a7177817b8cf0830b6894ba2d4320e3/tests/test_collector.py#L62-L77 that shows that the parser does indeed skip over source code lines?

HBehrens avatar Mar 02 '21 15:03 HBehrens

Thank you, @awujek !

You're welcome!

Do you think the default should be True instead of the picked False?

It is up to you. I wanted to keep it backward compatible;) But as a new user I would prefer to have the source by default:)

Also, could you do me a favour and add a test similar to

https://github.com/HBehrens/puncover/blob/706dcc5e4a7177817b8cf0830b6894ba2d4320e3/tests/test_collector.py#L62-L77 that shows that the parser does indeed skip over source code lines?

ok, let me check

awujek avatar Mar 02 '21 17:03 awujek

Sorry for the delay, @awujek – I hope that I will be able to get to this over the weekend.

HBehrens avatar Mar 05 '21 15:03 HBehrens